Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[NFT Metadata Crawler] Fix asset uploader throttler #15410

Merged
merged 2 commits into from
Nov 30, 2024

Conversation

just-in-chang
Copy link
Contributor

@just-in-chang just-in-chang commented Nov 27, 2024

Description

Quick fix to not panic

How Has This Been Tested?

Key Areas to Review

Type of Change

  • New feature
  • Bug fix
  • Breaking change
  • Performance improvement
  • Refactoring
  • Dependency update
  • Documentation update
  • Tests

Which Components or Systems Does This Change Impact?

  • Validator Node
  • Full Node (API, Indexer, etc.)
  • Move/Aptos Virtual Machine
  • Aptos Framework
  • Aptos CLI/SDK
  • Developer Infrastructure
  • Move Compiler
  • Other (specify)

Checklist

  • I have read and followed the CONTRIBUTING doc
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I identified and added all stakeholders and component owners affected by this change as reviewers
  • I tested both happy and unhappy path of the functionality
  • I have made corresponding changes to the documentation

Copy link

trunk-io bot commented Nov 27, 2024

⏱️ 1h 21m total CI duration on this PR
Slowest 15 Jobs Cumulative Duration Recent Runs
rust-move-tests 13m 🟩
test-target-determinator 13m 🟩🟩🟩
rust-move-tests 12m 🟩
rust-move-tests 12m 🟩
rust-cargo-deny 5m 🟩🟩🟩
rust-doc-tests 5m 🟩
execution-performance / test-target-determinator 5m 🟩
check-dynamic-deps 5m 🟩🟩🟩🟩
check 4m 🟩
general-lints 2m 🟩🟩🟩
fetch-last-released-docker-image-tag 2m 🟩
semgrep/ci 1m 🟩🟩🟩🟩
file_change_determinator 39s 🟩🟩🟩
file_change_determinator 30s 🟩🟩🟩
permission-check 11s 🟩🟩🟩🟩

🚨 1 job on the last run was significantly faster/slower than expected

Job Duration vs 7d avg Delta
execution-performance / single-node-performance 9s 18m -99%

settingsfeedbackdocs ⋅ learn more about trunk.io

@just-in-chang just-in-chang added the CICD:build-images when this label is present github actions will start build+push rust images from the PR. label Nov 27, 2024
@just-in-chang just-in-chang changed the title [NFT Metadata Crawler] Fix throttler [NFT Metadata Crawler] Fix asset uploader throttler Nov 27, 2024
@just-in-chang just-in-chang enabled auto-merge (squash) November 30, 2024 01:37

This comment has been minimized.

This comment has been minimized.

Copy link
Contributor

✅ Forge suite realistic_env_max_load success on a684e9822eb23abf447c357c1b16d3377cdb35c5

two traffics test: inner traffic : committed: 14127.03 txn/s, latency: 2813.89 ms, (p50: 2700 ms, p70: 2700, p90: 3000 ms, p99: 3300 ms), latency samples: 5371400
two traffics test : committed: 99.98 txn/s, latency: 1626.57 ms, (p50: 1400 ms, p70: 1600, p90: 2100 ms, p99: 5100 ms), latency samples: 1780
Latency breakdown for phase 0: ["MempoolToBlockCreation: max: 2.358, avg: 1.435", "ConsensusProposalToOrdered: max: 0.317, avg: 0.293", "ConsensusOrderedToCommit: max: 0.384, avg: 0.373", "ConsensusProposalToCommit: max: 0.676, avg: 0.666"]
Max non-epoch-change gap was: 0 rounds at version 0 (avg 0.00) [limit 4], 0.82s no progress at version 2078564 (avg 0.20s) [limit 15].
Max epoch-change gap was: 0 rounds at version 0 (avg 0.00) [limit 4], 15.64s no progress at version 2078562 (avg 14.70s) [limit 16].
Test Ok

Copy link
Contributor

✅ Forge suite compat success on 010570d3b7aa20889fb5ad0e5b23800aa33f5634 ==> a684e9822eb23abf447c357c1b16d3377cdb35c5

Compatibility test results for 010570d3b7aa20889fb5ad0e5b23800aa33f5634 ==> a684e9822eb23abf447c357c1b16d3377cdb35c5 (PR)
1. Check liveness of validators at old version: 010570d3b7aa20889fb5ad0e5b23800aa33f5634
compatibility::simple-validator-upgrade::liveness-check : committed: 14758.89 txn/s, latency: 2360.90 ms, (p50: 1800 ms, p70: 2100, p90: 3700 ms, p99: 8400 ms), latency samples: 549840
2. Upgrading first Validator to new version: a684e9822eb23abf447c357c1b16d3377cdb35c5
compatibility::simple-validator-upgrade::single-validator-upgrading : committed: 6950.59 txn/s, latency: 4089.51 ms, (p50: 4600 ms, p70: 4800, p90: 5100 ms, p99: 5100 ms), latency samples: 126240
compatibility::simple-validator-upgrade::single-validator-upgrade : committed: 6936.58 txn/s, latency: 4655.97 ms, (p50: 5000 ms, p70: 5300, p90: 6400 ms, p99: 6700 ms), latency samples: 230720
3. Upgrading rest of first batch to new version: a684e9822eb23abf447c357c1b16d3377cdb35c5
compatibility::simple-validator-upgrade::half-validator-upgrading : committed: 7946.44 txn/s, latency: 3584.44 ms, (p50: 4000 ms, p70: 4100, p90: 4200 ms, p99: 4300 ms), latency samples: 146480
compatibility::simple-validator-upgrade::half-validator-upgrade : committed: 7354.73 txn/s, latency: 4393.03 ms, (p50: 4300 ms, p70: 4300, p90: 7100 ms, p99: 7400 ms), latency samples: 276660
4. upgrading second batch to new version: a684e9822eb23abf447c357c1b16d3377cdb35c5
compatibility::simple-validator-upgrade::rest-validator-upgrading : committed: 11129.94 txn/s, latency: 2503.29 ms, (p50: 2500 ms, p70: 2600, p90: 4000 ms, p99: 4200 ms), latency samples: 207840
compatibility::simple-validator-upgrade::rest-validator-upgrade : committed: 11193.71 txn/s, latency: 2808.88 ms, (p50: 2600 ms, p70: 2700, p90: 5300 ms, p99: 6700 ms), latency samples: 361120
5. check swarm health
Compatibility test for 010570d3b7aa20889fb5ad0e5b23800aa33f5634 ==> a684e9822eb23abf447c357c1b16d3377cdb35c5 passed
Test Ok

@just-in-chang just-in-chang merged commit 1e926ed into main Nov 30, 2024
92 checks passed
@just-in-chang just-in-chang deleted the justin/fix-throttler branch November 30, 2024 02:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CICD:build-images when this label is present github actions will start build+push rust images from the PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants