Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FA] get rid of migration flag #15269

Merged
merged 1 commit into from
Dec 5, 2024
Merged

Conversation

lightmark
Copy link
Contributor

Description

  1. Will not create PFS when register account. Deposit will create that automatically.
  2. Get rid of unnecessary MigrationFlag.

How Has This Been Tested?

ut

Key Areas to Review

Type of Change

  • New feature
  • Bug fix
  • Breaking change
  • Performance improvement
  • Refactoring
  • Dependency update
  • Documentation update
  • Tests

Which Components or Systems Does This Change Impact?

  • Validator Node
  • Full Node (API, Indexer, etc.)
  • Move/Aptos Virtual Machine
  • Aptos Framework
  • Aptos CLI/SDK
  • Developer Infrastructure
  • Move Compiler
  • Other (specify)

Checklist

  • I have read and followed the CONTRIBUTING doc
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I identified and added all stakeholders and component owners affected by this change as reviewers
  • I tested both happy and unhappy path of the functionality
  • I have made corresponding changes to the documentation

Copy link

trunk-io bot commented Nov 13, 2024

⏱️ 1h 16m total CI duration on this PR
Job Cumulative Duration Recent Runs
rust-cargo-deny 11m 🟩🟩🟩🟩🟩 (+1 more)
check-dynamic-deps 11m 🟩🟩🟩🟩🟩 (+1 more)
rust-move-tests 9m 🟥
rust-move-tests 9m 🟩
rust-move-tests 8m 🟥
rust-move-tests 7m 🟥
rust-move-tests 7m 🟥
rust-move-tests 7m 🟥
general-lints 3m 🟩🟩🟩🟩🟩 (+1 more)
semgrep/ci 3m 🟩🟩🟩🟩🟩 (+1 more)
file_change_determinator 1m 🟩🟩🟩🟩🟩 (+1 more)
permission-check 26s 🟩🟩🟩🟩🟩 (+2 more)
permission-check 26s 🟩🟩🟩🟩🟩 (+2 more)

🚨 1 job on the last run was significantly faster/slower than expected

Job Duration vs 7d avg Delta
check-dynamic-deps 3m 1m +102%

settingsfeedbackdocs ⋅ learn more about trunk.io

@lightmark lightmark requested review from igor-aptos, WGB5445, davidiw and movekevin and removed request for davidiw, alinush, wrwg and movekevin November 13, 2024 22:43
@lightmark lightmark force-pushed the lightmark/deprecate_migration_flag branch from 9c614c4 to 77a70c2 Compare November 13, 2024 23:54
@lightmark lightmark force-pushed the lightmark/deprecate_migration_flag branch from 77a70c2 to e9d3ee5 Compare November 15, 2024 05:02
@lightmark lightmark force-pushed the lightmark/deprecate_migration_flag branch 5 times, most recently from daea913 to 0e82d73 Compare November 21, 2024 00:34
@lightmark lightmark force-pushed the lightmark/deprecate_migration_flag branch from 0e82d73 to 23a5985 Compare November 21, 2024 01:59

This comment has been minimized.

This comment has been minimized.

@lightmark lightmark force-pushed the lightmark/deprecate_migration_flag branch 2 times, most recently from 26d8dde to 1bbbaa2 Compare December 4, 2024 20:02

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

@lightmark lightmark force-pushed the lightmark/deprecate_migration_flag branch 2 times, most recently from 1b5b7ca to 14a8957 Compare December 4, 2024 23:21

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

@lightmark lightmark force-pushed the lightmark/deprecate_migration_flag branch from 14a8957 to 371da9b Compare December 5, 2024 00:12

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

Copy link
Contributor

github-actions bot commented Dec 5, 2024

✅ Forge suite realistic_env_max_load success on 371da9b523b422975d3d0e4cc20859a33a0b7747

two traffics test: inner traffic : committed: 14914.39 txn/s, latency: 2661.63 ms, (p50: 2700 ms, p70: 2700, p90: 2900 ms, p99: 3000 ms), latency samples: 5670740
two traffics test : committed: 99.94 txn/s, latency: 1412.28 ms, (p50: 1400 ms, p70: 1400, p90: 1500 ms, p99: 2200 ms), latency samples: 1800
Latency breakdown for phase 0: ["MempoolToBlockCreation: max: 1.502, avg: 1.451", "ConsensusProposalToOrdered: max: 0.336, avg: 0.291", "ConsensusOrderedToCommit: max: 0.374, avg: 0.359", "ConsensusProposalToCommit: max: 0.658, avg: 0.649"]
Max non-epoch-change gap was: 1 rounds at version 40679 (avg 0.00) [limit 4], 2.05s no progress at version 40679 (avg 0.20s) [limit 15].
Max epoch-change gap was: 0 rounds at version 0 (avg 0.00) [limit 4], 0.71s no progress at version 2475624 (avg 0.71s) [limit 16].
Test Ok

Copy link
Contributor

github-actions bot commented Dec 5, 2024

✅ Forge suite compat success on 3527aa2e299553b759c515d9843586bad48c802c ==> 371da9b523b422975d3d0e4cc20859a33a0b7747

Compatibility test results for 3527aa2e299553b759c515d9843586bad48c802c ==> 371da9b523b422975d3d0e4cc20859a33a0b7747 (PR)
1. Check liveness of validators at old version: 3527aa2e299553b759c515d9843586bad48c802c
compatibility::simple-validator-upgrade::liveness-check : committed: 17323.30 txn/s, latency: 1973.70 ms, (p50: 2100 ms, p70: 2100, p90: 2200 ms, p99: 2400 ms), latency samples: 555340
2. Upgrading first Validator to new version: 371da9b523b422975d3d0e4cc20859a33a0b7747
compatibility::simple-validator-upgrade::single-validator-upgrading : committed: 7442.25 txn/s, latency: 3883.20 ms, (p50: 4300 ms, p70: 4600, p90: 4700 ms, p99: 4700 ms), latency samples: 141200
compatibility::simple-validator-upgrade::single-validator-upgrade : committed: 7111.83 txn/s, latency: 4605.50 ms, (p50: 4600 ms, p70: 4700, p90: 6400 ms, p99: 6900 ms), latency samples: 236760
3. Upgrading rest of first batch to new version: 371da9b523b422975d3d0e4cc20859a33a0b7747
compatibility::simple-validator-upgrade::half-validator-upgrading : committed: 6778.43 txn/s, latency: 4168.32 ms, (p50: 4600 ms, p70: 4900, p90: 5600 ms, p99: 5800 ms), latency samples: 125600
compatibility::simple-validator-upgrade::half-validator-upgrade : committed: 7108.35 txn/s, latency: 4581.02 ms, (p50: 4900 ms, p70: 5000, p90: 5300 ms, p99: 6600 ms), latency samples: 234480
4. upgrading second batch to new version: 371da9b523b422975d3d0e4cc20859a33a0b7747
compatibility::simple-validator-upgrade::rest-validator-upgrading : committed: 11185.67 txn/s, latency: 2502.00 ms, (p50: 2700 ms, p70: 2900, p90: 3200 ms, p99: 3300 ms), latency samples: 196340
compatibility::simple-validator-upgrade::rest-validator-upgrade : committed: 11661.96 txn/s, latency: 2759.03 ms, (p50: 2900 ms, p70: 3000, p90: 3100 ms, p99: 3500 ms), latency samples: 379120
5. check swarm health
Compatibility test for 3527aa2e299553b759c515d9843586bad48c802c ==> 371da9b523b422975d3d0e4cc20859a33a0b7747 passed
Test Ok

Copy link
Contributor

github-actions bot commented Dec 5, 2024

✅ Forge suite framework_upgrade success on 3527aa2e299553b759c515d9843586bad48c802c ==> 371da9b523b422975d3d0e4cc20859a33a0b7747

Compatibility test results for 3527aa2e299553b759c515d9843586bad48c802c ==> 371da9b523b422975d3d0e4cc20859a33a0b7747 (PR)
Upgrade the nodes to version: 371da9b523b422975d3d0e4cc20859a33a0b7747
framework_upgrade::framework-upgrade::full-framework-upgrade : committed: 1401.18 txn/s, submitted: 1405.25 txn/s, failed submission: 4.07 txn/s, expired: 4.07 txn/s, latency: 2074.50 ms, (p50: 1800 ms, p70: 2100, p90: 3300 ms, p99: 4500 ms), latency samples: 123840
framework_upgrade::framework-upgrade::full-framework-upgrade : committed: 1112.59 txn/s, submitted: 1114.16 txn/s, failed submission: 1.57 txn/s, expired: 1.57 txn/s, latency: 2675.26 ms, (p50: 1800 ms, p70: 2500, p90: 6000 ms, p99: 7800 ms), latency samples: 99080
5. check swarm health
Compatibility test for 3527aa2e299553b759c515d9843586bad48c802c ==> 371da9b523b422975d3d0e4cc20859a33a0b7747 passed
Upgrade the remaining nodes to version: 371da9b523b422975d3d0e4cc20859a33a0b7747
framework_upgrade::framework-upgrade::full-framework-upgrade : committed: 1269.94 txn/s, submitted: 1273.28 txn/s, failed submission: 3.34 txn/s, expired: 3.34 txn/s, latency: 2483.86 ms, (p50: 2100 ms, p70: 2400, p90: 4500 ms, p99: 7300 ms), latency samples: 114060
Test Ok

@lightmark lightmark merged commit c2969f0 into main Dec 5, 2024
48 checks passed
@lightmark lightmark deleted the lightmark/deprecate_migration_flag branch December 5, 2024 00:43
danielxiangzl pushed a commit that referenced this pull request Dec 12, 2024
* [FA] get rid of migration flag

* fixup! [FA] get rid of migration flag
danielxiangzl pushed a commit that referenced this pull request Dec 12, 2024
* [FA] get rid of migration flag

* fixup! [FA] get rid of migration flag
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants