-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FA] get rid of migration flag #15269
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lightmark
requested review from
alinush,
davidiw,
movekevin and
wrwg
as code owners
November 13, 2024 22:42
⏱️ 1h 16m total CI duration on this PR
🚨 1 job on the last run was significantly faster/slower than expected
|
lightmark
requested review from
igor-aptos,
WGB5445,
davidiw and
movekevin
and removed request for
davidiw,
alinush,
wrwg and
movekevin
November 13, 2024 22:43
lightmark
force-pushed
the
lightmark/deprecate_migration_flag
branch
from
November 13, 2024 23:54
9c614c4
to
77a70c2
Compare
lightmark
force-pushed
the
lightmark/deprecate_migration_flag
branch
from
November 15, 2024 05:02
77a70c2
to
e9d3ee5
Compare
lightmark
requested review from
msmouse,
grao1991,
banool,
gregnazario and
0xmaayan
as code owners
November 15, 2024 05:02
lightmark
force-pushed
the
lightmark/deprecate_migration_flag
branch
5 times, most recently
from
November 21, 2024 00:34
daea913
to
0e82d73
Compare
lightmark
requested review from
zekun000,
vgao1996 and
georgemitenkov
as code owners
November 21, 2024 00:34
lightmark
force-pushed
the
lightmark/deprecate_migration_flag
branch
from
November 21, 2024 01:59
0e82d73
to
23a5985
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
lightmark
force-pushed
the
lightmark/deprecate_migration_flag
branch
2 times, most recently
from
December 4, 2024 20:02
26d8dde
to
1bbbaa2
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
lightmark
force-pushed
the
lightmark/deprecate_migration_flag
branch
2 times, most recently
from
December 4, 2024 23:21
1b5b7ca
to
14a8957
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
lightmark
force-pushed
the
lightmark/deprecate_migration_flag
branch
from
December 5, 2024 00:12
14a8957
to
371da9b
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
✅ Forge suite
|
✅ Forge suite
|
✅ Forge suite
|
danielxiangzl
pushed a commit
that referenced
this pull request
Dec 12, 2024
* [FA] get rid of migration flag * fixup! [FA] get rid of migration flag
danielxiangzl
pushed a commit
that referenced
this pull request
Dec 12, 2024
* [FA] get rid of migration flag * fixup! [FA] get rid of migration flag
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
MigrationFlag
.How Has This Been Tested?
ut
Key Areas to Review
Type of Change
Which Components or Systems Does This Change Impact?
Checklist