[pipeline] integration #15164

zekun000 · 2024-11-01T22:55:55Z

Description

This pr integrates the pipeline framework from #15145 to existing code, and use a local config to gate it.

How Has This Been Tested?

Key Areas to Review

Type of Change

Which Components or Systems Does This Change Impact?

Checklist

I have read and followed the CONTRIBUTING doc
I have performed a self-review of my own code
I have commented my code, particularly in hard-to-understand areas
I identified and added all stakeholders and component owners affected by this change as reviewers
I tested both happy and unhappy path of the functionality
I have made corresponding changes to the documentation

trunk-io · 2024-11-01T22:55:58Z

⏱️ 3h 2m total CI duration on this PR

Slowest 15 Jobs	Cumulative Duration	Recent Runs
test-target-determinator	41m	🟩 🟩 🟩 🟩 🟩 (+4 more)
rust-cargo-deny	21m	🟩 🟩 🟩 🟩 🟩 (+7 more)
check-dynamic-deps	16m	🟩 🟩 🟩 🟩 🟩 (+8 more)
rust-images / rust-all	14m	🟩
rust-move-tests	9m	🟩
rust-move-tests	9m	🟩
rust-move-tests	9m	🟩
rust-move-tests	9m	🟩
rust-move-tests	9m	🟩
rust-move-tests	9m	🟩
rust-move-tests	9m	🟩
general-lints	6m	🟩 🟩 🟩 🟩 🟩 (+7 more)
semgrep/ci	5m	🟩 🟩 🟩 🟩 🟩 (+9 more)
rust-move-tests	4m	⬜
file_change_determinator	2m	🟩 🟩 🟩 🟩 🟩 (+7 more)

_{settings ⋅ feedback ⋅ docs ⋅ learn more about trunk.io}

ibalajiarun · 2024-11-13T23:44:57Z

testsuite/smoke-test/src/smoke_test_environment.rs

@@ -17,7 +17,7 @@ use rand::rngs::OsRng;
 use std::{num::NonZeroUsize, sync::Arc};
 use tokio::task::JoinHandle;

-const SWARM_BUILD_NUM_RETRIES: u8 = 3;
+const SWARM_BUILD_NUM_RETRIES: u8 = 0;


ibalajiarun · 2024-11-13T23:58:06Z

consensus/src/pipeline/execution_schedule_phase.rs

+            for b in &ordered_blocks {
+                if let Some(tx) = b.pipeline_tx().lock().as_mut() {
+                    tx.rand_tx.take().map(|tx| tx.send(b.randomness().cloned()));
+                    let _ = tx.order_proof_tx.send(());


probably log if it's an error?

ibalajiarun · 2024-11-14T00:51:18Z

consensus/src/pipeline/persisting_phase.rs

+        {
+            for b in &blocks {
+                if let Some(tx) = b.pipeline_tx().lock().as_mut() {
+                    let _ = tx.commit_proof_tx.send(commit_ledger_info.clone());


same as previous: probably log error.

github-actions · 2024-11-14T03:24:33Z

✅ Forge suite `realistic_env_max_load` success on `7c08c63cf5cd9ae70d1eddb868429b0186df1fb5`

two traffics test: inner traffic : committed: 14466.39 txn/s, latency: 2749.98 ms, (p50: 2700 ms, p70: 2700, p90: 2900 ms, p99: 3000 ms), latency samples: 5500520
two traffics test : committed: 99.98 txn/s, latency: 1472.18 ms, (p50: 1300 ms, p70: 1400, p90: 1600 ms, p99: 8500 ms), latency samples: 1700
Latency breakdown for phase 0: ["MempoolToBlockCreation: max: 2.005, avg: 1.579", "ConsensusProposalToOrdered: max: 0.331, avg: 0.293", "ConsensusOrderedToCommit: max: 0.367, avg: 0.352", "ConsensusProposalToCommit: max: 0.654, avg: 0.645"]
Max non-epoch-change gap was: 0 rounds at version 0 (avg 0.00) [limit 4], 0.97s no progress at version 2411752 (avg 0.20s) [limit 15].
Max epoch-change gap was: 0 rounds at version 0 (avg 0.00) [limit 4], 8.59s no progress at version 2411750 (avg 8.59s) [limit 15].
Test Ok

github-actions · 2024-11-14T03:26:18Z

✅ Forge suite `framework_upgrade` success on `a0ec6ba11bfe4cfc5b586edc9e227aba4909e8fe` ==> `7c08c63cf5cd9ae70d1eddb868429b0186df1fb5`

Compatibility test results for a0ec6ba11bfe4cfc5b586edc9e227aba4909e8fe ==> 7c08c63cf5cd9ae70d1eddb868429b0186df1fb5 (PR)
Upgrade the nodes to version: 7c08c63cf5cd9ae70d1eddb868429b0186df1fb5
framework_upgrade::framework-upgrade::full-framework-upgrade : committed: 1304.08 txn/s, submitted: 1306.95 txn/s, failed submission: 2.87 txn/s, expired: 2.87 txn/s, latency: 2340.31 ms, (p50: 2100 ms, p70: 2400, p90: 4200 ms, p99: 5400 ms), latency samples: 118260
framework_upgrade::framework-upgrade::full-framework-upgrade : committed: 1247.30 txn/s, submitted: 1251.03 txn/s, failed submission: 3.72 txn/s, expired: 3.72 txn/s, latency: 2483.78 ms, (p50: 2400 ms, p70: 2700, p90: 3600 ms, p99: 6000 ms), latency samples: 107200
5. check swarm health
Compatibility test for a0ec6ba11bfe4cfc5b586edc9e227aba4909e8fe ==> 7c08c63cf5cd9ae70d1eddb868429b0186df1fb5 passed
Upgrade the remaining nodes to version: 7c08c63cf5cd9ae70d1eddb868429b0186df1fb5
framework_upgrade::framework-upgrade::full-framework-upgrade : committed: 1290.90 txn/s, submitted: 1294.23 txn/s, failed submission: 3.33 txn/s, expired: 3.33 txn/s, latency: 2314.95 ms, (p50: 2100 ms, p70: 2400, p90: 3600 ms, p99: 4500 ms), latency samples: 116200
Test Ok

github-actions · 2024-11-14T03:31:19Z

✅ Forge suite `compat` success on `a0ec6ba11bfe4cfc5b586edc9e227aba4909e8fe` ==> `7c08c63cf5cd9ae70d1eddb868429b0186df1fb5`

Compatibility test results for a0ec6ba11bfe4cfc5b586edc9e227aba4909e8fe ==> 7c08c63cf5cd9ae70d1eddb868429b0186df1fb5 (PR)
1. Check liveness of validators at old version: a0ec6ba11bfe4cfc5b586edc9e227aba4909e8fe
compatibility::simple-validator-upgrade::liveness-check : committed: 18498.47 txn/s, latency: 1852.91 ms, (p50: 1900 ms, p70: 1900, p90: 2100 ms, p99: 2200 ms), latency samples: 590060
2. Upgrading first Validator to new version: 7c08c63cf5cd9ae70d1eddb868429b0186df1fb5
compatibility::simple-validator-upgrade::single-validator-upgrading : committed: 7949.35 txn/s, latency: 3623.74 ms, (p50: 4100 ms, p70: 4200, p90: 4300 ms, p99: 4400 ms), latency samples: 148240
compatibility::simple-validator-upgrade::single-validator-upgrade : committed: 7138.27 txn/s, latency: 4439.69 ms, (p50: 4400 ms, p70: 4500, p90: 6700 ms, p99: 6900 ms), latency samples: 235540
3. Upgrading rest of first batch to new version: 7c08c63cf5cd9ae70d1eddb868429b0186df1fb5
compatibility::simple-validator-upgrade::half-validator-upgrading : committed: 7608.74 txn/s, latency: 3688.79 ms, (p50: 4200 ms, p70: 4400, p90: 4500 ms, p99: 4600 ms), latency samples: 139620
compatibility::simple-validator-upgrade::half-validator-upgrade : committed: 7755.19 txn/s, latency: 4169.80 ms, (p50: 4400 ms, p70: 4500, p90: 5700 ms, p99: 5900 ms), latency samples: 252620
4. upgrading second batch to new version: 7c08c63cf5cd9ae70d1eddb868429b0186df1fb5
compatibility::simple-validator-upgrade::rest-validator-upgrading : committed: 12085.95 txn/s, latency: 2307.66 ms, (p50: 2500 ms, p70: 2600, p90: 2800 ms, p99: 3000 ms), latency samples: 210780
compatibility::simple-validator-upgrade::rest-validator-upgrade : committed: 10459.40 txn/s, latency: 2960.13 ms, (p50: 2600 ms, p70: 2800, p90: 6000 ms, p99: 7700 ms), latency samples: 341680
5. check swarm health
Compatibility test for a0ec6ba11bfe4cfc5b586edc9e227aba4909e8fe ==> 7c08c63cf5cd9ae70d1eddb868429b0186df1fb5 passed
Test Ok

zekun000 force-pushed the zekun/pipeline2 branch from 18946e0 to e03085f Compare November 4, 2024 22:47

zekun000 added the CICD:run-forge-e2e-perf Run the e2e perf forge only label Nov 4, 2024