Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

turn off consensus observer #15154

Closed
wants to merge 3 commits into from
Closed

turn off consensus observer #15154

wants to merge 3 commits into from

Conversation

bchocho
Copy link
Contributor

@bchocho bchocho commented Nov 1, 2024

Description

How Has This Been Tested?

Key Areas to Review

Type of Change

  • New feature
  • Bug fix
  • Breaking change
  • Performance improvement
  • Refactoring
  • Dependency update
  • Documentation update
  • Tests

Which Components or Systems Does This Change Impact?

  • Validator Node
  • Full Node (API, Indexer, etc.)
  • Move/Aptos Virtual Machine
  • Aptos Framework
  • Aptos CLI/SDK
  • Developer Infrastructure
  • Move Compiler
  • Other (specify)

Checklist

  • I have read and followed the CONTRIBUTING doc
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I identified and added all stakeholders and component owners affected by this change as reviewers
  • I tested both happy and unhappy path of the functionality
  • I have made corresponding changes to the documentation

Copy link

trunk-io bot commented Nov 1, 2024

@bchocho bchocho added CICD:build-failpoints-images Build failpoints docker image CICD:build-performance-images build performance docker image variants CICD:run-forge-e2e-perf Run the e2e perf forge only labels Nov 1, 2024

This comment has been minimized.

This comment has been minimized.

perryjrandall and others added 2 commits November 1, 2024 13:01
Add junit support for forge

This will allow us to onboard forge onto trunk flaky test detection

Also make suite choice more clean

Test Plan: running on PR

This comment has been minimized.

Copy link
Contributor

github-actions bot commented Nov 1, 2024

✅ Forge suite realistic_env_max_load success on f12a4d88e796580cf5b8916fa118b10248108134

two traffics test: inner traffic : committed: 14325.42 txn/s, latency: 2774.56 ms, (p50: 2700 ms, p70: 2700, p90: 3000 ms, p99: 3600 ms), latency samples: 5446900
two traffics test : committed: 99.96 txn/s, latency: 2075.38 ms, (p50: 2100 ms, p70: 2200, p90: 2300 ms, p99: 3400 ms), latency samples: 1860
Latency breakdown for phase 0: ["MempoolToBlockCreation: max: 1.236, avg: 0.828", "ConsensusProposalToOrdered: max: 0.319, avg: 0.295", "ConsensusOrderedToCommit: max: 0.360, avg: 0.350", "ConsensusProposalToCommit: max: 0.654, avg: 0.645"]
Max non-epoch-change gap was: 0 rounds at version 0 (avg 0.00) [limit 4], 0.77s no progress at version 2746271 (avg 0.20s) [limit 15].
Max epoch-change gap was: 0 rounds at version 0 (avg 0.00) [limit 4], 8.21s no progress at version 2746267 (avg 8.21s) [limit 15].
Test Ok

@bchocho bchocho closed this Dec 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CICD:build-failpoints-images Build failpoints docker image CICD:build-performance-images build performance docker image variants CICD:run-forge-e2e-perf Run the e2e perf forge only
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants