Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] Inconsistency between Move.toml and source code addresses #411

Closed
borispovod opened this issue Apr 5, 2022 · 1 comment
Closed
Assignees
Labels
bug Something isn't working

Comments

@borispovod
Copy link
Contributor

🐛 Bug

At the page of the official tutorial, you rely on buggy behaviour, which allows to specify hex address without prefix. In case of hex number without a-f symbols in it, it could leads to confusion, as same address would mean different things in manifest and in sources.

Using 0x also make it easier to understand, as move users got used to the mandatory prefix in addresses.

See the linked issue in Move.

To reproduce

  • Go to tutorial.
  • See addresses in the output:
=== Addresses ===
Alice: e26d69b8d3ff12874358da6a4082a2ac
Bob: c8585f009c8a90f22c6b603f28b9ed8c
  • Try to update Move.toml with provided address:
A1 = "0xe26d69b8d3ff12874358da6a4082a2ac" # with prefix
A2 = "e26d69b8d3ff12874358da6a4082a2ac" # without prefix

Expected Behavior

Would be good to create and follow some standard which allows to use addresses only with 0x prefix, also in Move.toml.

@borispovod borispovod added the bug Something isn't working label Apr 5, 2022
@gregnazario
Copy link
Contributor

Thanks for reporting the bug! I've bene looking into what we can do in general to help this experience so that it's consistent with 0x in front.

@davidiw davidiw closed this as completed Jun 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants