Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include notebook in testing #154

Open
lkct opened this issue Nov 27, 2023 · 3 comments
Open

Include notebook in testing #154

lkct opened this issue Nov 27, 2023 · 3 comments
Labels
low-priority Low priority issues testing Related to (unit) testing the library

Comments

@lkct
Copy link
Member

lkct commented Nov 27, 2023

As indicated in #153, we can forget to update the notebook when the API changes.

It should be better to have a unit test to guarantee that the notebook can still run after some change.

@lkct lkct added the testing Related to (unit) testing the library label Nov 27, 2023
@loreloc
Copy link
Member

loreloc commented Apr 1, 2024

As a long term view for the repository, perhaps move notebooks to another repository.
The reason is that we do not need versioning for the majority of the bits stored in a notebook (e.g., images).

@lkct lkct added this to the April 2024 Workshop milestone Apr 1, 2024
@loreloc loreloc removed this from the Cirkit 0.1.0 milestone Sep 17, 2024
@loreloc
Copy link
Member

loreloc commented Oct 28, 2024

@loreloc loreloc added the low-priority Low priority issues label Oct 28, 2024
@loreloc
Copy link
Member

loreloc commented Oct 28, 2024

Might be worth looking into https://github.com/chrisjsewell/pytest-notebook

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
low-priority Low priority issues testing Related to (unit) testing the library
Projects
None yet
Development

No branches or pull requests

2 participants