From e492f45d7b7841995f6e7b1ba4e753a2e607bfa4 Mon Sep 17 00:00:00 2001 From: Alex Lementuev Date: Thu, 28 Jan 2021 19:04:13 -0500 Subject: [PATCH] Apptentive Android SDK 5.6.2 --- CHANGELOG.md | 6 ++++++ README.md | 2 +- apptentive/consumer-proguard-rules.pro | 3 ++- .../android/sdk/conversation/ConversationMetadata.java | 5 ++++- .../java/com/apptentive/android/sdk/util/Constants.java | 2 +- 5 files changed, 14 insertions(+), 4 deletions(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index c1cfb5ddd..c8f43202a 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -1,3 +1,9 @@ +# 2021-01-28 - v5.6.2 + +#### Fixes + +* Google Play Core library ProGuard fixes. + # 2021-01-04 - v5.6.1 #### Improvements diff --git a/README.md b/README.md index 63e30a6c6..d00adcd3d 100644 --- a/README.md +++ b/README.md @@ -13,7 +13,7 @@ use your app, to talk to them at the right time, and in the right way. ##### [Release Notes](https://learn.apptentive.com/knowledge-base/android-sdk-release-notes/) -##### Binary releases are hosted for Maven [here](http://search.maven.org/#artifactdetails|com.apptentive|apptentive-android|5.6.1|aar) +##### Binary releases are hosted for Maven [here](http://search.maven.org/#artifactdetails|com.apptentive|apptentive-android|5.6.2|aar) #### Reporting Bugs diff --git a/apptentive/consumer-proguard-rules.pro b/apptentive/consumer-proguard-rules.pro index 208bc198a..d69035764 100644 --- a/apptentive/consumer-proguard-rules.pro +++ b/apptentive/consumer-proguard-rules.pro @@ -12,8 +12,9 @@ -keep class * implements com.apptentive.android.sdk.serialization.SerializableObject { *; } -keep class com.apptentive.android.sdk.** implements java.io.Serializable { *; } - -keep class android.os.Build { *; } -keep class android.graphics.Typeface { *; } -keep class androidx.fragment.app.Fragment { *; } -keep class androidx.fragment.app.FragmentManagerImpl { *; } + +-keep class com.google.android.play.core.review.** { *; } diff --git a/apptentive/src/main/java/com/apptentive/android/sdk/conversation/ConversationMetadata.java b/apptentive/src/main/java/com/apptentive/android/sdk/conversation/ConversationMetadata.java index cc2a967d2..54ac61625 100644 --- a/apptentive/src/main/java/com/apptentive/android/sdk/conversation/ConversationMetadata.java +++ b/apptentive/src/main/java/com/apptentive/android/sdk/conversation/ConversationMetadata.java @@ -4,7 +4,6 @@ import com.apptentive.android.sdk.util.StringUtils; import java.io.DataInput; -import java.io.DataInputStream; import java.io.DataOutput; import java.io.IOException; import java.util.ArrayList; @@ -131,6 +130,10 @@ private static void hackR8() { // touch the constructor and "use" the reference ConversationMetadata c = new ConversationMetadata(stream); System.out.println(c); + + // some R8 configurations also remove google in-app review library classes + com.google.android.play.core.review.ReviewManager factory = com.google.android.play.core.review.ReviewManagerFactory.create(null); + System.out.println(factory); } } catch (Exception ignored) { } diff --git a/apptentive/src/main/java/com/apptentive/android/sdk/util/Constants.java b/apptentive/src/main/java/com/apptentive/android/sdk/util/Constants.java index 64e8113c0..94b72e353 100644 --- a/apptentive/src/main/java/com/apptentive/android/sdk/util/Constants.java +++ b/apptentive/src/main/java/com/apptentive/android/sdk/util/Constants.java @@ -9,7 +9,7 @@ public class Constants { public static final int API_VERSION = 10; - private static final String APPTENTIVE_SDK_VERSION = "5.6.1"; + private static final String APPTENTIVE_SDK_VERSION = "5.6.2"; public static final int DEFAULT_CONNECT_TIMEOUT_MILLIS = 45000; public static final int DEFAULT_READ_TIMEOUT_MILLIS = 45000;