Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

reporter_that_creates_an_approval_script doesn't work on Windows #57

Open
JayBazuzi opened this issue Dec 15, 2024 · 0 comments
Open

reporter_that_creates_an_approval_script doesn't work on Windows #57

JayBazuzi opened this issue Dec 15, 2024 · 0 comments

Comments

@JayBazuzi
Copy link

  • It writes a .sh file, should be .cmd
  • It writes Unix-style newlines (\n), should be Windows-style (\r\n)
  • It writes a Bash shebang header (#!/bin/bash), should not

Also, neither Windows nor Unix-like scripts have any error handling; maybe that is OK.

Also, tests!

Suggestion: separate out a data structure that describes what needs to be done from a "formatter" that writes it as a script.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@JayBazuzi