Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

IO errors are not handled when UseFolder points to non-existing directory #49

Open
thmshmm opened this issue Oct 31, 2024 · 0 comments
Open

IO errors are not handled when UseFolder points to non-existing directory #49

thmshmm opened this issue Oct 31, 2024 · 0 comments

Comments

@thmshmm
Copy link

thmshmm commented Oct 31, 2024

When UseFolder is set to a non-existing directory

go-approval-tests/approvals.go

Line 78 in 434b910

err := namer.compare(namer.getApprovalFile(extWithDot), namer.getReceivedFile(extWithDot), reader)

just received does not match approved is logged instead of the actual no such file or directory
error that was generated in dumpReceivedTestResult.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@thmshmm