Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

warning C4459 in MSVC with /W4 #193

Closed
rick-de-water opened this issue Feb 4, 2022 · 1 comment
Closed

warning C4459 in MSVC with /W4 #193

rick-de-water opened this issue Feb 4, 2022 · 1 comment

Comments

@rick-de-water
Copy link

The following warning gets emitted a lot when building using Visual studio 2022 and warning level 4.

ApprovalTests.hpp(4954, 77) : warning C4459 : declaration of 'path' hides global declaration
  ApprovalTests.hpp(4495, 10) : message: see declaration of 'ApprovalTests::path'[xxx.vcxproj]
ApprovalTests.hpp(4961, 40) : warning C4459 : declaration of 'path' hides global declaration
  ApprovalTests.hpp(4495, 10) : message: see declaration of 'ApprovalTests::path'[xxx.vcxproj]
ApprovalTests.hpp(4968, 21) : warning C4459 : declaration of 'path' hides global declaration
  ApprovalTests.hpp(4495, 10) : message: see declaration of 'ApprovalTests::path'[xxx.vcxproj]
ApprovalTests.hpp(4977, 21) : warning C4459 : declaration of 'path' hides global declaration
  ApprovalTests.hpp(4495, 10) : message: see declaration of 'ApprovalTests::path'[xxx.vcxproj]
ApprovalTests.hpp(5104, 30) : warning C4459 : declaration of 'path' hides global declaration
  ApprovalTests.hpp(4495, 10) : message: see declaration of 'ApprovalTests::path'[xxx.vcxproj]
ApprovalTests.hpp(6163, 51) : warning C4459 : declaration of 'path' hides global declaration
  ApprovalTests.hpp(4495, 10) : message: see declaration of 'ApprovalTests::path'[xxx.vcxproj]
ApprovalTests.hpp(6171, 48) : warning C4459 : declaration of 'path' hides global declaration
  ApprovalTests.hpp(4495, 10) : message: see declaration of 'ApprovalTests::path'[xxx.vcxproj]
ApprovalTests.hpp(6366, 28) : warning C4459 : declaration of 'path' hides global declaration
  ApprovalTests.hpp(4495, 10) : message: see declaration of 'ApprovalTests::path'[xxx.vcxproj]
ApprovalTests.hpp(6375, 70) : warning C4459 : declaration of 'path' hides global declaration
  ApprovalTests.hpp(4495, 10) : message: see declaration of 'ApprovalTests::path'[xxx.vcxproj]
ApprovalTests.hpp(6416, 62) : warning C4459 : declaration of 'path' hides global declaration
  ApprovalTests.hpp(4495, 10) : message: see declaration of 'ApprovalTests::path'[xxx.vcxproj]
ApprovalTests.hpp(6769, 42) : warning C4459 : declaration of 'path' hides global declaration
  ApprovalTests.hpp(4495, 10) : message: see declaration of 'ApprovalTests::path'[xxx.vcxproj]

I manually changed the name for now but it should probably have a unique name in a future release.
claremacrae added a commit that referenced this issue Feb 25, 2022
@claremacrae @isidore
R Fix warning C4459 in MSVC with /W4 - see #193
f2825eb 
Co-Authored-By: Llewellyn Falco <[email protected]>
@claremacrae
Copy link
Collaborator

Thank you. This should be fixed in the next release, later today.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@rick-de-water @claremacrae