Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ApprovalTests.cpp's tests and examples should never be built when used as a sub-project #179

Closed
claremacrae opened this issue Apr 23, 2021 · 1 comment
Closed

ApprovalTests.cpp's tests and examples should never be built when used as a sub-project #179

claremacrae opened this issue Apr 23, 2021 · 1 comment

Comments

@claremacrae
Copy link
Collaborator

The intention in this project's CMake scripts is never to build our tests and examples by default, when we are used as a sub-project.

However, a mistake in this CMake code meant that if a parent project had set NOT_SUBPROJECT to ON, then our tests and examples would be built and run.

This was fixed in commit 94192f8.
@claremacrae
Copy link
Collaborator Author

Fixed in 94192f8

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@claremacrae