Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

If received and approved filenames are identical, tests spuriously pass #178

Closed
claremacrae opened this issue Apr 20, 2021 · 1 comment
Closed
Assignees
Labels
bug namers Code for naming and finding approved and received files

Comments

@claremacrae
Copy link
Collaborator

I was playing around with custom namers, and accidentally generated a namer that generated identical received and approved file names.

I then wrote a test that I expected to fail, as the approved content didn't match the source code.

However it passed!

And I eventually worked out that it was because it was effectively testing if received content matched received content, which always passes!

@claremacrae claremacrae self-assigned this Apr 20, 2021
@claremacrae claremacrae added namers Code for naming and finding approved and received files bug labels Apr 20, 2021
@claremacrae
Copy link
Collaborator Author

This will be fixed in the next release

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug namers Code for naming and finding approved and received files
Projects
None yet
Development

No branches or pull requests

1 participant