Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Windows 2019 builds on Github Actions failing due to Boost being removed #175

Closed
claremacrae opened this issue Mar 13, 2021 · 0 comments
Closed

Windows 2019 builds on Github Actions failing due to Boost being removed #175

claremacrae opened this issue Mar 13, 2021 · 0 comments

Comments

@claremacrae
Copy link
Collaborator

As described in actions/runner-images#2667

I assume I'll need to implement this:
actions/runner-images#2667 (comment)

I know that we're pinned on ubuntu-18.04 for the same reason -boost is not included in ubuntu-20.04 - so it would be good for boost to be added in a way that it can be downloaded on ubuntu-20.04 too - then we could update the ubuntu version.
claremacrae added a commit that referenced this issue Mar 20, 2021
@claremacrae
Use Conan to install Boost 1.72 on Windows (#175)
fb89e83
claremacrae added a commit that referenced this issue Mar 22, 2021
@claremacrae
e Update minimum CMake to 3.12 (#175)
0b94833 
It turns out that the BOOST_ROOT value set in
github_actions_build.yml was being ignored, because
CMake behaviour was set to before 3.12, and so
the CMake policy CMP0074 was to ignore BOOST_ROOT.

I could have set the policy to change the CMP0074
behaviour, but decided to update the CMake minimum
version instead.
claremacrae added a commit that referenced this issue Mar 22, 2021
@claremacrae
e Improve BOOST_ROOT value, having tested on Windows (#175)
acb2c3d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@claremacrae