-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove the need for out-of-source build trees with non-Unity Ninja builds #171
Comments
Because of this issue, I've experiment with adding some code to And if it finds the source file there, it remembers the amount of "../" that it needed to add, and uses that in the remaining tests in that test suite run. The code is a bit ugly at the moment - but it's a big improvement in behaviour, as we would be able to get rid of most or all of this Troubleshooting page, for newer releases: https://github.com/approvals/ApprovalTests.cpp/blob/master/doc/TroubleshootingMisconfiguredBuild.md .... and we would also get rid of the compile-time check as to whether the build was configured correctly... |
The code so far is here - it runs on all CI platforms... Things that definitely need to be done:
|
This is fixed in the soon-to-be-released v.10.8.0 |
Co-Authored-By: Llewellyn Falco <[email protected]>
In a project where I'm using ApprovalTests, and I'm out-of-source builds so that Ninja CI builds should work, I'm finding that the compile-time error check is being triggered...
https://github.com/approvals/ApprovalTests.cpp/blob/master/doc/TroubleshootingMisconfiguredBuild.md#compilation-error
... I expected this Ninja build to work, because I'm doing out-of-source builds...
It's happened in one project where I'm loading the ApprovalTests.cpp project via CMake's FetchContent - so even though the build tree is outside the source directory, FetchContent is putting ApprovalTests inside the build-tree - which I think is resulting in relative paths...
This is another situation:
claremacrae/ApprovalTests.cpp.CMakeSamples#5
The text was updated successfully, but these errors were encountered: