Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create valid image files for new image-based approval tests #7

Closed
claremacrae opened this issue Sep 6, 2021 · 2 comments
Closed

Create valid image files for new image-based approval tests #7

claremacrae opened this issue Sep 6, 2021 · 2 comments

Comments

@claremacrae
Copy link
Contributor

Currently, an empty (0-byte) .png file is created, which causes diff tools to say things like:

"Unable to load the image file. It might not be one of the supported formats."
@claremacrae
Copy link
Contributor Author

The addition of a seam in ApprovalTest for this should make this fairly easy to implement:
approvals/ApprovalTests.cpp#172

@claremacrae
Copy link
Contributor Author

This is now done and will be in the next release

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@claremacrae