Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rspec extension specs don't clean up after themselves #68

Open
kytrinyx opened this issue Oct 22, 2015 · 0 comments
Open

rspec extension specs don't clean up after themselves #68

kytrinyx opened this issue Oct 22, 2015 · 0 comments

Comments

@kytrinyx
Copy link
Contributor

The tests in spec/extensions/rspec_approvals_spec.rb lines 64 - 78 leave the *received.txt files even when the tests pass. They also add entries in the .approvals file.

This gets in the way when there are other failures and you're using the command line tool to step through each of the diffs one at a time.

$ cat .approvals 
spec/fixtures/approvals/verifies_a_failure.approved.txt spec/fixtures/approvals/verifies_a_failure.received.txt
spec/fixtures/approvals/verifies_a_failure_diff.approved.txt spec/fixtures/approvals/verifies_a_failure_diff.received.txt
spec/fixtures/approvals/verifies_directory/a_failure.approved.txt spec/fixtures/approvals/verifies_directory/a_failure.received.txt
spec/fixtures/approvals/verifies_directory/a_failure_diff.approved.txt spec/fixtures/approvals/verifies_directory/a_failure_diff.received.txt
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant