Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

asSurfaceLuminance does not work #348

Open
dictoon opened this issue Jan 14, 2020 · 2 comments
Open

asSurfaceLuminance does not work #348

dictoon opened this issue Jan 14, 2020 · 2 comments
Labels

Comments

@dictoon
Copy link
Member

dictoon commented Jan 14, 2020

The reason is that its output is of type float, and we try to connect it to the input of type color of as_max_closure2surface:

2020-01-14T12:55:23.911009Z <001>  1751 MB error   | osl: ConnectShaders: cannot connect a float (out_result) to a closure color (in_input)
2020-01-14T12:55:23.912010Z <001>  1751 MB error   | error connecting shaders Material #45_mat::out_result -> Material #45_mat_closure_2_surface_name::in_input.
@dictoon dictoon added the Bug label Jan 14, 2020
@usakhelo
Copy link
Contributor

Yes, I remember this. I think if we just re-arrange output parameters and put output closure color out_color = 0 first and output float out_result = 0 second it should fix the issue. I'll try and let you now.

@dictoon
Copy link
Member Author

dictoon commented Jan 18, 2020

That would be awesome, please do keep me posted!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants