Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[$30] Copilot Feedback Form #4399

Closed
ajefts opened this issue Jun 29, 2021 · 14 comments
Closed

[$30] Copilot Feedback Form #4399

ajefts opened this issue Jun 29, 2021 · 14 comments

Comments

@ajefts
Copy link
Contributor

ajefts commented Jun 29, 2021

New Feature:

Add a feature to allow a project user to leave feedback for the copilots on the project.

We have a typeform to handle the capture of the feedback: https://topcoder.typeform.com/to/vgqiBXdk#copilot=xxxxx&projectid=xxxxx&submitter=xxxxx

Let's add a link/action next to each copilot so that a project user can leave individual feedback for each copilot:
image

Note that the TypeForm URL needs to have the copilot handle, project_id, and handle of the person submitting the feedback.

Nice to have: Do not provide the feedback option to Copilots on the project. If the current user is a copilot on the project, then hide the feedback links.

@ajefts
Copy link
Contributor Author

ajefts commented Jun 29, 2021

fyi @vikasrohit

@vikasrohit
Copy link

@yoution can you please wrap this one quickly?

@yoution
Copy link
Collaborator

yoution commented Jul 6, 2021

@vikasrohit please assign to me

yoution added a commit to yoution/connect-app that referenced this issue Jul 6, 2021
@yoution
Copy link
Collaborator

yoution commented Jul 6, 2021

@vikasrohit please review #4402

vikasrohit pushed a commit that referenced this issue Jul 7, 2021
@vikasrohit
Copy link

@yoution it looks good. Can you please style the Feedback button to look like Manage button and also please change Feed Back to Feedback or better can we use the icon for feedback which is there down at the bottom for the application feedback link?

@yoution
Copy link
Collaborator

yoution commented Jul 8, 2021

@vikasrohit
how about this one?
image

yoution added a commit to yoution/connect-app that referenced this issue Jul 8, 2021
@yoution
Copy link
Collaborator

yoution commented Jul 8, 2021

change to this style, please review #4404
on the other hand, there is no payment in this ticket
image

vikasrohit pushed a commit that referenced this issue Jul 8, 2021
@vikasrohit vikasrohit changed the title Copilot Feedback Form [$30] Copilot Feedback Form Jul 8, 2021
@vikasrohit
Copy link

@yoution screenshot looks good, I have just merged it to feature branch. Will check on dev and come back to you.

I have also updated the prize money for it, let me know if it is not okay.

@vikasrohit vikasrohit added this to the 2.22.0 milestone Jul 9, 2021
vikasrohit pushed a commit that referenced this issue Jul 12, 2021
* fix: issue #4399

* Temp deployable feature branch

* fix: issue #4399

Co-authored-by: yoution <[email protected]>
@lakshmiathreya
Copy link

-- Verified Copilot feedback form for Manager role.
-- @vikasrohit the form is visible for Copilot role as well - pls clarify regarding this.

@lakshmiathreya
Copy link

-- Team member is able to see the feedback form as well - pls clarify regarding this.

@vikasrohit
Copy link

vikasrohit commented Jul 12, 2021

-- @vikasrohit the form is visible for Copilot role as well - pls clarify regarding this.

@lakshmiathreya good catch here. We haven't thought of role based access yet. We can log it as separate issue and handle it later.

-- Team member is able to see the feedback form as well - pls clarify regarding this.

I think that is in fact the requirement, we want any project member to be able to do so, however, we just need to confirm about copilots. Most probably we won't allow copilots to give feedback for themselves. :) @ajefts what are your thoughts?

@lakshmiathreya
Copy link

yes @vikasrohit - Team member feedback is the primary intent I guess. Just need clarification regarding form visibility for Copilot.

@vikasrohit
Copy link

Lets log a separate issue for that, we will get it fixed in next cycle.

@lakshmiathreya
Copy link

The form visibility needs to be Role based. Closing the Issue - pending fix for Copilot role visibility tracked in #4420

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants