Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add rubocop.yml #44

Open
heratyian opened this issue Jun 10, 2024 · 1 comment
Open

Add rubocop.yml #44

heratyian opened this issue Jun 10, 2024 · 1 comment

Comments

@heratyian
Copy link

Any thoughts on including a simplified rubocop.yml config here? I find it's been helpful to have it enabled to encourage good style.

@bpurinton
Copy link
Contributor

My concern here is that this template is geared towards beginners, and having them stopped in their tracks by formatting issues while trying to make commits in Phase 1 is not ideal (if the code runs fine as is). Formatting and linting seem more like a Phase 2 skill / aside, and not core content. It seems like that is already in place here: https://learn.firstdraft.com/lessons/390-style ? So perhaps just adding anything there (including a link to a gist with the copyable yml file?)

Nice lesson by the way!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants