Reconcile dev after merge to main for v1.52.1
#5893
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Edward Huang <[email protected]>
Co-authored-by: Maria Elisabeth Schreiber <[email protected]> Co-authored-by: Renée <[email protected]>
Co-authored-by: bryn <[email protected]>
…ipeline This fixes a weakness (classified as [CWE-770]) which made it possible to exceed the configured request payload maximums set with the [`limits.http_max_request_bytes`] configuration option when used in conjunction with certain configurations. Review the Github Advisory, [GHSA-x6xq-whh3-gg32], for specific details and impacted configurations. After the fix: - Request body payload limits are now enforced earlier in the pipeline, ensuring that coprocessors and user plugins respect the configured limit. - Reading a request body beyond the configured limit will abort the request and return a [HTTP 413] (Content Too Large) response to the client rather than delgating to the code consuming the body. To use different limits, `limits.http_max_request_bytes` must be configured to the desired value. - Coprocessors, Rhai and Rust plugins do NOT have an opportunity to intercept aborted requests. Use the telemetry features of the router to observe HTTP 413 events. [CWE-770]: https://cwe.mitre.org/data/definitions/770.html [GHSA-x6xq-whh3-gg32]: GHSA-x6xq-whh3-gg32 [HTTP 413]: https://developer.mozilla.org/en-US/docs/Web/HTTP/Status/413 [`limits.http_max_request_bytes`]: https://www.apollographql.com/docs/router/configuration/overview/#http_max_request_bytes --------- Co-authored-by: bryn <[email protected]> Co-authored-by: Gary Pennington <[email protected]> Co-authored-by: Jeremy Lempereur <[email protected]>
…rolled recursion Update the version of `@apollo/query-planner` used by Router to correct an uncontrolled recursion weakness (classified as [CWE-674]) during query planning for complex queries on particularly complex graphs. This weakness impacts all versions of Router. See the associated Github Advisory, [GHSA-fmj9-77q8-g6c4], for more information. [CWE-674]: https://cwe.mitre.org/data/definitions/674.html [GHSA-fmj9-77q8-g6c4]: GHSA-fmj9-77q8-g6c4
This will patch the Dockerfile to set the appropriate metadata for the publishing repository.
abernix
requested review from
a team,
dariuszkuc,
sachindshinde,
goto-bus-stop,
SimonSapin,
lrlna,
TylerBloom and
duckki
as code owners
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up to the v1.52.1 being officially released, bringing version bumps and changelog updates into the
devbranch.