-
Notifications
You must be signed in to change notification settings - Fork 271
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Configure targetPort via Helm #5672
base: dev
Are you sure you want to change the base?
Configure targetPort via Helm #5672
Conversation
Now the targetPort can be configured via the values.yaml
CI performance tests
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
helm/chart/router/README.md
needs updating with these additions
Not required. This will happen automatically during release when we invoke |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add a changeset to the PR following the instructions in .changesets/README.md
.
also: please make the PR title a little more descriptive.
✅ Docs Preview ReadyNo new or changed pages found. |
Hi @garypen, have created the required changeset. If anything missed please let me know. Thanks. |
A simple set of changes to the service and values file as required by customer
Checklist
Complete the checklist (and note appropriate exceptions) before the PR is marked ready-for-review.
Exceptions
Note any exceptions here
Notes
Footnotes
It may be appropriate to bring upcoming changes to the attention of other (impacted) groups. Please endeavour to do this before seeking PR approval. The mechanism for doing this will vary considerably, so use your judgement as to how and when to do this. ↩
Configuration is an important part of many changes. Where applicable please try to document configuration examples. ↩
Tick whichever testing boxes are applicable. If you are adding Manual Tests, please document the manual testing (extensively) in the Exceptions. ↩