You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository has been archived by the owner on Apr 14, 2023. It is now read-only.
The pink text in the code tags looks really fun and adds personality to the docs design, but it's difficult to read. Especially in articles like the Federation error codes doc where much of the page copy is in this format.
And finally, the fact that it is a bright color could easily confuse readers to wonder if it is in fact also a link. 😕
I know it's not as fun, but i'd suggest we move to simply black (or Apollo SpaceKit'sblack-base value of #191C23).
We could use something a little bit more fun and still has better contrast (like indigo-dark, #3F20BA), but my concern here still is that using any color is going to signal that it's a link, which in fact it is not.
Any objections to a PR that would update the code snippets to black-base?
(Note: to clarify, I'm only suggesting updating the styling for inline code ticks at this point; I consider syntax highlighting in the code blocks a much different matter because they're not read like prose, and generally I think the pink is much more appropriate there)
The text was updated successfully, but these errors were encountered:
The pink text in the code tags looks really fun and adds personality to the docs design, but it's difficult to read. Especially in articles like the Federation error codes doc where much of the page copy is in this format.
I'm also sad to report that it fails WCAG accessibility for color contrast pretty hard.
And finally, the fact that it is a bright color could easily confuse readers to wonder if it is in fact also a link. 😕
I know it's not as fun, but i'd suggest we move to simply black (or Apollo SpaceKit's
black-base
value of#191C23
).We could use something a little bit more fun and still has better contrast (like
indigo-dark
,#3F20BA
), but my concern here still is that using any color is going to signal that it's a link, which in fact it is not.Any objections to a PR that would update the code snippets to
black-base
?(Note: to clarify, I'm only suggesting updating the styling for inline code ticks at this point; I consider syntax highlighting in the code blocks a much different matter because they're not read like prose, and generally I think the pink is much more appropriate there)
The text was updated successfully, but these errors were encountered: