Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feature: @oneOf input object support #537

Open
wants to merge 12 commits into
base: main
Choose a base branch
from
Open

feature: @oneOf input object support #537

wants to merge 12 commits into from

Conversation

BobaFetters
Copy link
Member

Adding support for @OneOf Input Objects, more info can be found in the official RFC here: graphql/graphql-spec#825

Closes apollographql/apollo-ios#3430

@svc-apollo-docs
Copy link
Collaborator

svc-apollo-docs commented Nov 13, 2024 •
edited
Loading

✅ Docs Preview Ready

No new or changed pages found.

@BobaFetters BobaFetters self-assigned this Nov 13, 2024
@netlify Netlify
Copy link

netlify bot commented Nov 13, 2024 •
edited
Loading

✅ Deploy Preview for apollo-ios-docc canceled.

Name Link
🔨 Latest commit 68ba835
🔍 Latest deploy log https://app.netlify.com/sites/apollo-ios-docc/deploys/6748025387c6420008be7baa

@netlify Netlify
Copy link

netlify bot commented Nov 13, 2024 •
edited
Loading

✅ Deploy Preview for eclectic-pie-88a2ba ready!

Name Link
🔨 Latest commit 68ba835
🔍 Latest deploy log https://app.netlify.com/sites/eclectic-pie-88a2ba/deploys/67480253a4d305000806694b
😎 Deploy Preview https://deploy-preview-537--eclectic-pie-88a2ba.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

AnthonyMDev
AnthonyMDev approved these changes Nov 13, 2024
View reviewed changes
Copy link
Contributor

@AnthonyMDev AnthonyMDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor comment, but otherwise this looks good!

apollo-ios-codegen/Sources/ApolloCodegenLib/Templates/OneOfInputObjectTemplate.swift Outdated Show resolved Hide resolved
apollo-ios/Sources/ApolloAPI/SchemaTypes/InputObject.swift Show resolved Hide resolved
@BobaFetters
Removing unused fields
cb03e7e
@BobaFetters
Merge branch 'main' into feature/oneof-3430
e10c778
@BobaFetters
Updating Test Codegen config
bb3cce4 
Updating the SPMInXcodeProject codegen config to commit the animal kingdom package.swift and use local version of library
@BobaFetters
Revert "Updating Test Codegen config"
ad57e8a 
This reverts commit bb3cce4.
calvincestari
calvincestari approved these changes Nov 14, 2024
View reviewed changes
Copy link
Member

@calvincestari calvincestari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good Zach, thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AnthonyMDev AnthonyMDev AnthonyMDev approved these changes

@calvincestari calvincestari calvincestari approved these changes

Assignees

@BobaFetters BobaFetters

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Suport for OneOf Input Objects
4 participants
@BobaFetters @svc-apollo-docs @calvincestari @AnthonyMDev