Move internal/executable/os/exec to pkg/execute/exec #156
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your contribution, @robin-rpr! I will merge it into an interim branch where I’ll make some changes to the documentation, changelog, and so on. After that, I’ll merge it into the main branch. However, I won’t create a new tag just yet. |
apenella
added a commit
that referenced
this pull request
Aug 16, 2024
apenella
added a commit
that referenced
this pull request
Aug 16, 2024
|
Thank you so much @apenella ! This is highly appreciated and thank you so much for taking the time for this! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello there,
I am submitting suggestive change for fixing #155
This change would move the
execpackage frominternal/topkg/.It has to be mentioned that this Pull Request is not mature enough yet to be proceed with until it's clarified if this change is making sense. Discussion about this should happen at #155
Best regards,
Robin