Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: wrong its ready condition during image in-place update #8505

Merged
merged 3 commits into from
Nov 22, 2024

Conversation

free6om
Copy link
Contributor

@free6om free6om commented Nov 22, 2024

No description provided.

@free6om free6om added this to the Release 1.0.0 milestone Nov 22, 2024
@free6om free6om self-assigned this Nov 22, 2024
@free6om free6om requested a review from a team as a code owner November 22, 2024 03:14
@github-actions github-actions bot added the size/L Denotes a PR that changes 100-499 lines. label Nov 22, 2024
@apecloud-bot apecloud-bot added the approved PR Approved Test label Nov 22, 2024
Copy link

codecov bot commented Nov 22, 2024

Codecov Report

Attention: Patch coverage is 60.00000% with 2 lines in your changes missing coverage. Please review.

Project coverage is 60.61%. Comparing base (fe24a3a) to head (b3530a1).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
pkg/controller/instanceset/reconciler_update.go 0.00% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #8505      +/-   ##
==========================================
+ Coverage   60.35%   60.61%   +0.25%     
==========================================
  Files         357      357              
  Lines       42555    42554       -1     
==========================================
+ Hits        25684    25793     +109     
+ Misses      14559    14451     -108     
+ Partials     2312     2310       -2     
Flag Coverage Δ
unittests 60.61% <60.00%> (+0.25%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@leon-inf leon-inf linked an issue Nov 22, 2024 that may be closed by this pull request
@free6om free6om merged commit e5893a4 into main Nov 22, 2024
37 of 39 checks passed
@free6om free6om deleted the bugfix/wrong-its-ready-condition branch November 22, 2024 03:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved PR Approved Test size/L Denotes a PR that changes 100-499 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG]Milvus components were not upgraded as expected
4 participants