Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Improvement] Support restartTrigger #8623

Open
sophon-zt opened this issue Dec 11, 2024 · 0 comments
Open

[Improvement] Support restartTrigger #8623

sophon-zt opened this issue Dec 11, 2024 · 0 comments
Assignees
Labels
kind/enhancement New feature or request

Comments

@sophon-zt
Copy link
Contributor

Current implementation:
If the "reloadAction" is defined, execute this reloadAction to implement configuration changes.
If the "reloadAction" isn't defined, the pod will be restarted to implement the configuration change.

The "autoTrigger" seems rather redundant as it defines a autoTrigger to tell the operator that nothing needs to be done.

A better approach:
Define a "restartTrigger" which tells the operator to implement the reload by restarting. If the "reloadAction" isn't defined, the operator doesn't need to do anything.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant