Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: remove repetitive folds in Z3Context #3006

Merged
merged 9 commits into from
Oct 4, 2024
Merged

Conversation

konnov
Copy link
Collaborator

@konnov konnov commented Sep 27, 2024

I have noticed a few repetitive occurrences of summing up longs. Refactored that to a single call.

@konnov konnov requested review from thpani and Kukovec September 27, 2024 16:14
@konnov konnov requested a review from rodrigo7491 as a code owner September 27, 2024 16:14
Copy link
Collaborator

@thpani thpani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would it be possible / easier to use Seq.sum?

@konnov konnov enabled auto-merge September 30, 2024 15:52
@konnov
Copy link
Collaborator Author

konnov commented Sep 30, 2024

Would it be possible / easier to use Seq.sum?

Fixed that. Please review

@konnov konnov merged commit 9e9d099 into main Oct 4, 2024
10 checks passed
@thpani thpani deleted the igor/z3-refactor-toExpr branch October 4, 2024 15:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants