Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Invalid aria roles used #102

Open
ApinisMikelis opened this issue Aug 16, 2023 · 1 comment
Open

Invalid aria roles used #102

ApinisMikelis opened this issue Aug 16, 2023 · 1 comment

Comments

@ApinisMikelis
Copy link

This dependency introduces accessibility issues:
https://github.com/rstacruz/nprogress

It is using invalid aria roles. The repo has a lot of issues about this and even pull-requests, but it seems like the package is just abandoned.

Here is the issue:
https://github.com/rstacruz/nprogress/issues/232

In the issue there is a forked version mentioned where this is resolved (and the repo is not abandoned):
https://github.com/nmackey/accessible-nprogress

I suggest switching these dependencies..

@mirko-kienle
Copy link

We've run into this issue as well with automated a11y tests. Second the suggestion to switch dependencies to the forked version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants