From 14f37f6a8603f0efe96075c233af406ee41ce642 Mon Sep 17 00:00:00 2001 From: "Alvaro.Nogueira" Date: Fri, 3 Nov 2023 13:28:36 +0100 Subject: [PATCH 1/2] #28518 Add unit tests for SingleIndexReviser --- .../reviser/index/SingleIndexReviserTest.java | 48 +++++++++++++++++++ 1 file changed, 48 insertions(+) create mode 100644 kernel/single/core/src/test/java/org/apache/shardingsphere/single/metadata/reviser/index/SingleIndexReviserTest.java diff --git a/kernel/single/core/src/test/java/org/apache/shardingsphere/single/metadata/reviser/index/SingleIndexReviserTest.java b/kernel/single/core/src/test/java/org/apache/shardingsphere/single/metadata/reviser/index/SingleIndexReviserTest.java new file mode 100644 index 0000000000000..e2dc254ef8659 --- /dev/null +++ b/kernel/single/core/src/test/java/org/apache/shardingsphere/single/metadata/reviser/index/SingleIndexReviserTest.java @@ -0,0 +1,48 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.shardingsphere.single.metadata.reviser.index; + +import org.apache.shardingsphere.infra.database.core.metadata.data.model.IndexMetaData; +import org.junit.jupiter.api.Test; + +import java.util.Optional; + +import static org.hamcrest.CoreMatchers.is; +import static org.hamcrest.MatcherAssert.assertThat; +import static org.junit.jupiter.api.Assertions.assertTrue; + +class SingleIndexReviserTest { + + @Test + void assertReviserReturnsRevisedIndex() { + SingleIndexReviser reviser = new SingleIndexReviser(); + IndexMetaData originalMetaData = new IndexMetaData("test_idx_tableName"); + originalMetaData.getColumns().add("column1"); + originalMetaData.getColumns().add("column2"); + originalMetaData.setUnique(true); + + Optional optionalRevised = reviser.revise("tableName", originalMetaData, null); + + assertTrue(optionalRevised.isPresent()); + IndexMetaData actual = optionalRevised.get(); + assertThat(originalMetaData.isUnique(), is(actual.isUnique())); + assertThat(originalMetaData.getColumns(), is(actual.getColumns())); + assertThat("test_idx", is(actual.getName())); + } + +} From 5b2bd19e65ab47656aa8661ffee66ab17ae08441 Mon Sep 17 00:00:00 2001 From: "Alvaro.Nogueira" Date: Fri, 3 Nov 2023 14:58:05 +0100 Subject: [PATCH 2/2] #28518 Add unit tests for SingleIndexReviser --- .../metadata/reviser/index/SingleIndexReviserTest.java | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/kernel/single/core/src/test/java/org/apache/shardingsphere/single/metadata/reviser/index/SingleIndexReviserTest.java b/kernel/single/core/src/test/java/org/apache/shardingsphere/single/metadata/reviser/index/SingleIndexReviserTest.java index e2dc254ef8659..e1881ea7d27b8 100644 --- a/kernel/single/core/src/test/java/org/apache/shardingsphere/single/metadata/reviser/index/SingleIndexReviserTest.java +++ b/kernel/single/core/src/test/java/org/apache/shardingsphere/single/metadata/reviser/index/SingleIndexReviserTest.java @@ -30,19 +30,16 @@ class SingleIndexReviserTest { @Test void assertReviserReturnsRevisedIndex() { - SingleIndexReviser reviser = new SingleIndexReviser(); IndexMetaData originalMetaData = new IndexMetaData("test_idx_tableName"); originalMetaData.getColumns().add("column1"); originalMetaData.getColumns().add("column2"); originalMetaData.setUnique(true); - + SingleIndexReviser reviser = new SingleIndexReviser(); Optional optionalRevised = reviser.revise("tableName", originalMetaData, null); - assertTrue(optionalRevised.isPresent()); IndexMetaData actual = optionalRevised.get(); assertThat(originalMetaData.isUnique(), is(actual.isUnique())); assertThat(originalMetaData.getColumns(), is(actual.getColumns())); assertThat("test_idx", is(actual.getName())); } - }