Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add lock timeout in DistSQL #34134

Open
terrymanu opened this issue Dec 24, 2024 · 2 comments
Open

Add lock timeout in DistSQL #34134

terrymanu opened this issue Dec 24, 2024 · 2 comments

Comments

@terrymanu
Copy link
Member

Add lock timeout in DistSQL LOCK CLUSTER WITH lockStrategy and UNLOCK CLUSTER.

The new attribute LOCK TIMEOUT should be optional. The SQL should be:

LOCK CLUSTER WITH lockStrategy (TIMEOUT int)? and UNLOCK CLUSTER (TIMEOUT int)?.

The todolist should be:

  1. Update G4 file
  2. Update LockClusterExecutor and UnlockClusterExecutor with Add todo on cluster lock #34133's TODO
  3. Update document
  4. Add test cases
@lubochen
Copy link

Hi @terrymanu ,could you please assign this issue to me? Thank you.

@lubochen
Copy link

lubochen commented Dec 25, 2024

@terrymanu Hi,I'm sorry. I've encountered some issues while working on this task.
I'm not sure whether the timeout parameter should be added to the LOCK CLUSTER operation TypedSPILoader.getService(ClusterLockStrategy.class, sqlStatement.getLockStrategy().getName()).lock();
or if the timeout in lockContext.tryLock(lockDefinition, 3000L) should be used as the parameter. Could you please clarify?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants