Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support parsing SQL Server SELECT d.name, sql #29181

Closed
FlyingZC opened this issue Nov 24, 2023 · 5 comments · Fixed by #30154
Closed

Support parsing SQL Server SELECT d.name, sql #29181

FlyingZC opened this issue Nov 24, 2023 · 5 comments · Fixed by #30154

Comments

@FlyingZC
Copy link
Member

Background

Hi community.
This issue is for #29149.

The ShardingSphere SQL parser engine helps users to parse SQL to create the AST (Abstract Syntax Tree) and visit the AST to get SQLStatement (Java Object). Currently, we are planning to enhance the support for SQL Server SQL parsing in ShardingSphere.

More details:
https://shardingsphere.apache.org/document/current/en/reference/sharding/parse/

Task

This issue is to support more SQL Server sql parsing, as follows:

SELECT d.name, d.owner_sid, sl.name
FROM sys.databases AS d
JOIN sys.sql_logins AS sl
ON d.owner_sid = sl.sid

link

SELECT * FROM [@{item().TABLE_SCHEMA}].[@{item().TABLE_NAME}]

link

SELECT DISTINCT user.FirstName, user.LastName
INTO ms_user
FROM user INNER JOIN (
    SELECT * FROM ClickStream WHERE cs.url = 'www.microsoft.com'
    ) AS ms
ON user.user_ip = ms.user_ip

link

SELECT {[Measures].[Internet Sales Count], [Measures].[Internet Sales-Sales Amount]} ON COLUMNS, 
{[Product].[Product Line].[Product Line].MEMBERS} ON ROWS
FROM [Analysis Services Tutorial]
WHERE [Sales Territory].[Sales Territory Country].[Australia]

link

INSERT INTO #tmpdbs ([dbid], [dbname], [isdone])
SELECT database_id, name, 0 FROM master.sys.databases (NOLOCK) WHERE is_read_only = 0 AND state = 0

link

Process

  1. First confirm that this is a correct SQL Server sql syntax, if not please leave a message under the issue and ignore it;
  2. Compare SQL definitions in Official SQL Doc and ShardingSphere SQL Doc;
  3. If there is any difference in ShardingSphere SQL Doc, please correct them by referring to the Official SQL Doc;
  4. Run mvn install the current_file_module;
  5. Check whether there are any exceptions. If indeed, please fix them. (Especially xxxVisitor.class);
  6. Add new corresponding SQL case in SQL Cases and expected parsed result in Expected Statement XML;
  7. Run SQLParserParameterizedTest to make sure no exceptions.

Relevant Skills

  1. Master JAVA language
  2. Have a basic understanding of Antlr g4 file
  3. Be familiar with SQL Server SQLs
@dshunter107
Copy link
Contributor

Hello. Is anyone already working on this?

@strongduanmu
Copy link
Member

@dshunter107 No, you can try to solve this issue.

Copy link

There hasn't been any activity on this issue recently, and in order to prioritize active issues, it will be marked as stale.

@github-actions github-actions bot added the stale label Jan 15, 2024
@yydeng626
Copy link
Collaborator

Please assign to me

@strongduanmu strongduanmu assigned yydeng626 and unassigned dshunter107 Feb 2, 2024
@strongduanmu
Copy link
Member

@yydeng626 Assigned.

@github-actions github-actions bot removed the stale label Feb 2, 2024
yydeng626 added a commit to yydeng626/shardingsphere that referenced this issue Feb 6, 2024
yydeng626 added a commit to yydeng626/shardingsphere that referenced this issue Feb 17, 2024
strongduanmu pushed a commit that referenced this issue Feb 17, 2024
* Support parsing SQL Server SELECT d.name, sql #29181

* Support parsing SQL Server SELECT d.name, sql #29181
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants