Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support parsing SQL Server INSERT INTO sql #29168

Closed
FlyingZC opened this issue Nov 24, 2023 · 6 comments · Fixed by #29700
Closed

Support parsing SQL Server INSERT INTO sql #29168

FlyingZC opened this issue Nov 24, 2023 · 6 comments · Fixed by #29700

Comments

@FlyingZC
Copy link
Member

Background

Hi community.
This issue is for #29149.

The ShardingSphere SQL parser engine helps users to parse SQL to create the AST (Abstract Syntax Tree) and visit the AST to get SQLStatement (Java Object). Currently, we are planning to enhance the support for SQL Server SQL parsing in ShardingSphere.

More details:
https://shardingsphere.apache.org/document/current/en/reference/sharding/parse/

Task

This issue is to support more SQL Server sql parsing, as follows:

INSERT INTO #SampleTempTable VALUES (10, null)

link

INSERT INTO #SampleTempTable VALUES (17, 'abc')

link

INSERT INTO #SampleTempTable VALUES (17, 'yes')

link

INSERT INTO #SampleTempTable VALUES (null, null)

link

SELECT * FROM #SampleTempTable WHERE id IS NOT DISTINCT FROM NULL

link

Process

  1. First confirm that this is a correct SQL Server sql syntax, if not please leave a message under the issue and ignore it;
  2. Compare SQL definitions in Official SQL Doc and ShardingSphere SQL Doc;
  3. If there is any difference in ShardingSphere SQL Doc, please correct them by referring to the Official SQL Doc;
  4. Run mvn install the current_file_module;
  5. Check whether there are any exceptions. If indeed, please fix them. (Especially xxxVisitor.class);
  6. Add new corresponding SQL case in SQL Cases and expected parsed result in Expected Statement XML;
  7. Run SQLParserParameterizedTest to make sure no exceptions.

Relevant Skills

  1. Master JAVA language
  2. Have a basic understanding of Antlr g4 file
  3. Be familiar with SQL Server SQLs
Copy link

There hasn't been any activity on this issue recently, and in order to prioritize active issues, it will be marked as stale.

@github-actions github-actions bot added the stale label Dec 24, 2023
@TherChenYang
Copy link
Collaborator

@strongduanmu You can assign it to me. I noticed that #29167, #29166, and #29167 should all be of the same type as this issue. You can assign them to me collectively. Thanks

@strongduanmu
Copy link
Member

@TherChenYang Since you're not a committer in the community, you'll need to leave a comment on these issues before I can assign them.

@TherChenYang
Copy link
Collaborator

@TherChenYang Since you're not a committer in the community, you'll need to leave a comment on these issues before I can assign them.

Okay, I understand. Thank you. I will go and leave a comment.

@TherChenYang
Copy link
Collaborator

@strongduanmu Already submitted the PR, hope you can take a look when you have free time, thank you.

@strongduanmu
Copy link
Member

@strongduanmu Already submitted the PR, hope you can take a look when you have free time, thank you.

Good job, I will review this pr.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants