Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support parsing SQL Server SELECT TRIM( sql #29162

Closed
FlyingZC opened this issue Nov 24, 2023 · 7 comments · Fixed by #30249
Closed

Support parsing SQL Server SELECT TRIM( sql #29162

FlyingZC opened this issue Nov 24, 2023 · 7 comments · Fixed by #30249

Comments

@FlyingZC
Copy link
Member

Background

Hi community.
This issue is for #29149.

The ShardingSphere SQL parser engine helps users to parse SQL to create the AST (Abstract Syntax Tree) and visit the AST to get SQLStatement (Java Object). Currently, we are planning to enhance the support for SQL Server SQL parsing in ShardingSphere.

More details:
https://shardingsphere.apache.org/document/current/en/reference/sharding/parse/

Task

This issue is to support more SQL Server sql parsing, as follows:

SELECT TRIM( '.,! ' FROM '     #     test    .') AS Result

link

SELECT TRIM(LEADING '.,! ' FROM  '     .#     test    .') AS Result

link

SELECT TRIM(TRAILING '.,! ' FROM '     .#     test    .') AS Result

link

SELECT TRIM(BOTH '123' FROM '123abc123') AS Result

link

INSERT INTO [HR].[Employees]
        ([SSN]
        ,[FirstName]
        ,[LastName]
        ,[Salary])
    VALUES
        ('795-73-9838'
        , N'Catherine'
        , N'Abel'
        , $31692)

link

Process

  1. First confirm that this is a correct SQL Server sql syntax, if not please leave a message under the issue and ignore it;
  2. Compare SQL definitions in Official SQL Doc and ShardingSphere SQL Doc;
  3. If there is any difference in ShardingSphere SQL Doc, please correct them by referring to the Official SQL Doc;
  4. Run mvn install the current_file_module;
  5. Check whether there are any exceptions. If indeed, please fix them. (Especially xxxVisitor.class);
  6. Add new corresponding SQL case in SQL Cases and expected parsed result in Expected Statement XML;
  7. Run SQLParserParameterizedTest to make sure no exceptions.

Relevant Skills

  1. Master JAVA language
  2. Have a basic understanding of Antlr g4 file
  3. Be familiar with SQL Server SQLs
Copy link

There hasn't been any activity on this issue recently, and in order to prioritize active issues, it will be marked as stale.

@github-actions github-actions bot added the stale label Dec 24, 2023
venkatdatta0 added a commit to venkatdatta0/shardingsphere that referenced this issue Dec 25, 2023
venkatdatta0 added a commit to venkatdatta0/shardingsphere that referenced this issue Dec 25, 2023
@venkatdatta0
Copy link

Hi @FlyingZC
I am new to the community and trying to add the support for TRIM function.

Please review: #29542

Copy link

There hasn't been any activity on this issue recently, and in order to prioritize active issues, it will be marked as stale.

@strongduanmu
Copy link
Member

Hi @venkatdatta0, I'm so sorry for late repley. I will review this pr.

@zzzk1
Copy link
Contributor

zzzk1 commented Feb 21, 2024

Hi, @strongduanmu can you assigned this to me ? i want to try

@zhuruixuan
Copy link
Collaborator

@strongduanmu
Hello, Can you assign me this task? I'll try to solve it.

@strongduanmu
Copy link
Member

I assigned the task to @zzzk1 according to first come, first served basis. @zhuruixuan Are you interested in other SQL parsing tasks? There are many more tasks on our issue list.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment