Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support parsing SQL Server INSERT INTO sql #29152

Closed
FlyingZC opened this issue Nov 24, 2023 · 3 comments · Fixed by #29329
Closed

Support parsing SQL Server INSERT INTO sql #29152

FlyingZC opened this issue Nov 24, 2023 · 3 comments · Fixed by #29329

Comments

@FlyingZC
Copy link
Member

Background

Hi community.
This issue is for #29149.

The ShardingSphere SQL parser engine helps users to parse SQL to create the AST (Abstract Syntax Tree) and visit the AST to get SQLStatement (Java Object). Currently, we are planning to enhance the support for SQL Server SQL parsing in ShardingSphere.

More details:
https://shardingsphere.apache.org/document/current/en/reference/sharding/parse/

Task

This issue is to support more SQL Server sql parsing, as follows:

INSERT INTO dbo.T1 VALUES (1, N'Natalia')

link

INSERT INTO dbo.T1 VALUES (2, N'Mark')

link

INSERT INTO dbo.T1 VALUES (3, N'Randolph')

link

SELECT x.$(ColumnName)
FROM Person.Person x
WHERE x.BusinessEntityID < 5

link

INSERT INTO AdventureWorks2022.dbo.VariableTest(Col1)
VALUES('$(tablename)')

link

Process

  1. First confirm that this is a correct SQL Server sql syntax, if not please leave a message under the issue and ignore it;
  2. Compare SQL definitions in Official SQL Doc and ShardingSphere SQL Doc;
  3. If there is any difference in ShardingSphere SQL Doc, please correct them by referring to the Official SQL Doc;
  4. Run mvn install the current_file_module;
  5. Check whether there are any exceptions. If indeed, please fix them. (Especially xxxVisitor.class);
  6. Add new corresponding SQL case in SQL Cases and expected parsed result in Expected Statement XML;
  7. Run SQLParserParameterizedTest to make sure no exceptions.

Relevant Skills

  1. Master JAVA language
  2. Have a basic understanding of Antlr g4 file
  3. Be familiar with SQL Server SQLs
@TherChenYang
Copy link
Collaborator

hello, can you assign this task to me?

@strongduanmu
Copy link
Member

@TherChenYang Welcome, I will assign this issue to you.

@TherChenYang
Copy link
Collaborator

Hi @strongduanmu , if you have some spare time, please review and let me know if any changes are required in this PR. Thanks!

zihaoAK47 pushed a commit that referenced this issue Dec 12, 2023
* Support parsing SQL Server INSERT INTO sql(#29152)

* Fix the oracle parser error test

* solve this nchar problem by adjusting Oracle's lexical or grammatical rules

* pass the spotless:apply check

* Fix PostgreSQL E2E error
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants