Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add unit test for PipelineJobCenter #28542

Closed
sandynz opened this issue Sep 21, 2023 · 11 comments · Fixed by #28879
Closed

Add unit test for PipelineJobCenter #28542

sandynz opened this issue Sep 21, 2023 · 11 comments · Fixed by #28879

Comments

@sandynz
Copy link
Contributor

sandynz commented Sep 21, 2023

Hi community,

This issue is for #28487.

Aim

Add more unit tests for PipelineJobCenter to test its public functions to improve unit test coverage. Methods: addJob, isJobExisting, getJob, getJobItemContext, getShardingItems.

Unit test coverage can be viewed at: https://app.codecov.io/gh/apache/shardingsphere

Basic Qualifications

  • Java
  • Maven
  • Junit
@MihirKohli
Copy link

Willing to volunteer but i have no experience in unit testing? How to get started?

@sandynz
Copy link
Contributor Author

sandynz commented Sep 28, 2023

Hi @MihirKohli , welcome! You could have a look at some JUnit 5 tutorials and reference unit tests in kernel/data-pipeline/core/src/test/java/.

@AbhineshJha
Copy link
Contributor

AbhineshJha commented Oct 15, 2023

hey @MihirKohli ! can i work on this issue ? can u assign me ?

@20t3r
Copy link

20t3r commented Oct 19, 2023

@sandynz Hi, can I please work on this issue? I’m a uni student who’s new to open source projects, but I will try my best for the pull request.

@ShamithaReddy
Copy link

hey, anyone working on this issue?

@sandynz
Copy link
Contributor Author

sandynz commented Oct 23, 2023

hey @MihirKohli ! can i work on this issue ? can u assign me ?

Welcome. You could work on it. There's no response more than 2 weeks.

@MihirKohli
Copy link

hey @MihirKohli ! can i work on this issue ? can u assign me ?

Welcome. You could work on it. There's no response more than 2 weeks.

Currently i am facing some issues meanwhile you can assign it to someone else

@sandynz
Copy link
Contributor Author

sandynz commented Oct 23, 2023

OK, thanks. Welcome back

@HarshSawarkar
Copy link
Contributor

hey @sandynz Can i pick this issue?

@HarshSawarkar
Copy link
Contributor

HarshSawarkar commented Oct 27, 2023

I have raised a PR for the issue #28879.Here's the link
#28879
Please can you review.

@sandynz sandynz added this to the 5.4.2 milestone Nov 2, 2023
@sandynz
Copy link
Contributor Author

sandynz commented Nov 2, 2023

Thanks all friends! Welcome to pick other issues.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment