Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support parsing Oracle DROP DATABASE; sql #27135

Closed
FlyingZC opened this issue Jul 13, 2023 · 4 comments · Fixed by #29263
Closed

Support parsing Oracle DROP DATABASE; sql #27135

FlyingZC opened this issue Jul 13, 2023 · 4 comments · Fixed by #29263

Comments

@FlyingZC
Copy link
Member

Background

Hi community,
This issue is for #26878.

ShardingSphere parser engine helps users parse a SQL to get the AST (Abstract Syntax Tree) and visit this tree to get SQLStatement (Java Object). Currently, we are planning to enhance the support for Oracle SQL parsing in ShardingSphere.

More details:
https://shardingsphere.apache.org/document/current/en/reference/sharding/parse/

Task

This issue is to support more oracle sql parse, as follows:

DROP DATABASE;
DROP FUNCTION auth_orders;
EXEC DBMS_RLS.DROP_POLICY('OE','ORDERS','ORDERS_POLICY');
DROP FUNCTION oe.SecondMax;
DROP PROFILE clerk CASCADE;
DROP SEQUENCE oe.customers_seq;

Process

  1. First confirm that this is a correct oracle sql syntax, if not please ignore;
  2. Compare SQL definitions in Oficial SQL Doc and ShardingSphere SQL Doc;
  3. If there is any difference in ShardingSphere SQL Doc, please correct them by referring to the Official SQL Doc;
  4. Run mvn install the current_file_module;
  5. Check whether there are any exceptions. If indeed, please fix them. (Especially xxxVisitor.class);
  6. Add new corresponding SQL case in SQL Cases and expected parsed result in Expected Statment XML;
  7. Run SQLParserParameterizedTest to make sure no exceptions.

Relevant Skills

  1. Master JAVA language
  2. Have a basic understanding of Antlr g4 file
  3. Be familiar with Oracle SQLs
@boyjoy1127
Copy link
Contributor

Do not close the issue please, more PR may be pushed in the future.

@github-actions
Copy link

There hasn't been any activity on this issue recently, and in order to prioritize active issues, it will be marked as stale.

@github-actions github-actions bot added the stale label Aug 15, 2023
@taojintianxia taojintianxia modified the milestones: 5.4.1, 5.4.2 Sep 28, 2023
@github-actions github-actions bot removed the stale label Sep 28, 2023
@github-actions
Copy link

There hasn't been any activity on this issue recently, and in order to prioritize active issues, it will be marked as stale.

@chakkk309
Copy link
Contributor

Hi, I just checked this issue and added the drop-database SQL parse support, ref pr #29263.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants