-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CI: Replace current GitHub Actions test reporting solution with less verbose solution #16736
Comments
The change could be tested in your own fork (some instructions in https://pulsar.apache.org/contributing/#ci-testing-in-your-fork) before submitting a PR. |
https://github.blog/2022-05-09-supercharging-github-actions-with-job-summaries/ explains the new feature available in GitHub Actions which is used in action-junit-report . |
The issue had no activity for 30 days, mark with Stale label. |
running an experiment in lhotari#78 |
The experiments looks promising |
https://github.com/apache/pulsar/pull/17282/checks?check_run_id=8047947991 I notice another issue on test reports that the report can be assigned to multiple jobs. |
Fixes #16736 * [improve][CI] Replace test reporting with less verbose solution - uses https://github.com/mikepenz/action-junit-report which has been copied to https://github.com/apache/pulsar-test-infra/tree/master/action-junit-report * Address review comment: remove merge-test-reports action
Fixes #16736 * [improve][CI] Replace test reporting with less verbose solution - uses https://github.com/mikepenz/action-junit-report which has been copied to https://github.com/apache/pulsar-test-infra/tree/master/action-junit-report * Address review comment: remove merge-test-reports action (cherry picked from commit cb881d4)
Is your enhancement request related to a problem? Please describe.
We are currently using a test reporting solution based on https://github.com/dorny/test-reporter and there's a copy of this action in https://github.com/apache/pulsar-test-infra/tree/master/test-reporter .
The problem with this solution is that the test reporting is very verbose since it creates new check runs for the PR.
When there are failed tests, the PR will be marked failing even in cases where the tests pass in a later retry.
Describe the solution you'd like
There's an alternative solution in https://github.com/mikepenz/action-junit-report which is actively maintained.
It's possible to use this action with
annotate_only: 'true'
so that check runs aren't created at all. This is to mitigate the gap in GitHub Actions solution that check results cannot target a specific workflow when there are multiple active ones (more details in mikepenz/action-junit-report#40 (comment)).The action will create a report for each build job using a new method available in GitHub Actions. example: https://github.com/mikepenz/action-junit-report/actions/runs/2717236074#summary-7464569272
The text was updated successfully, but these errors were encountered: