Add support for the BCM2711 #15188

linguini1 · 2024-12-13T19:05:49Z

Summary

This PR adds semi-functional support for the BCM2711 and Raspberry Pi 4B. The working features are a Mini-UART shell which can boot into NSH. I have run OStest and confirmed it works. The latest changes also boot.

Impact

Although the feature implementation for this board is minimal right now, I hope that by releasing the work I've done so far it is easier for other community members to start adding drivers/features to the board's support on NuttX. Several people were interested in using the Pi 4B with NuttX and it's a reasonably popular development board, so having it fully supported will be an asset.

Testing

Built the documentation, ensured it looks correct.

Built the written code so far, which was tested by:

Connecting the RPi 4B to my computer via USB-TTL cable and playing around in the shell
Running test programs like OStest and getprime (succeeded)
Running i2ctool with some I2C devices connected to the board. I was able to dump the contents of an EEPROM but not much more, I am confused by the I2C register interface and haven't spent enough time to overcome these issues. Partial completeness is noted on the docs page.
Tested GPIO driver interface by performing basic operations such as echo 1 > /dev/gpio23 and checking with a multimeter that the GPIO has gone high, or connecting input to a GPIO and performing cat /dev/gpio23, etc.

OStest results log are attached
ostest-bcm2711.txt

…ich selected the wrong boot option and caused the binary not to load. This made me lose my mind for at least one hour debugging.

… not sure how to best do that.

…'----' of NSH before shell is unresponsive.

linguini1 · 2024-12-13T19:06:57Z

It is going to take me a while to squash all these commits

acassis · 2024-12-13T22:06:17Z

It is going to take me a while to squash all these commits

Hi @linguini1 I suggest you to squash in a way that the mental logic you used to get this port working be preserved.

You can use squash the commits that created the headers files and the commits that fix them. Then they will appear early as an initial commit.

Preserving it will be useful to help other people to do the port to other chips.

@xiaoxiang781216 what do you think?

lupyuen · 2024-12-14T02:43:17Z

arch/arm64/src/bcm2711/bcm2711_serial.c

+    }
+
+  bcm2711_miniuart_wait_send(dev, ch);
+#endif // CONSOLE_DEV


Remove // CONSOLE_DEV or switch to /* ... */

lupyuen · 2024-12-14T02:43:34Z

arch/arm64/src/bcm2711/bcm2711_serial.c

+    {
+      _err("Could not register /dev/console, ret=%d\n", ret);
+    }
+#endif // defined(CONSOLE_DEV)


Remove // ... or switch to /* ... */

lupyuen · 2024-12-14T02:43:55Z

arch/arm64/src/bcm2711/bcm2711_serial.h

+
+#ifndef __ASSEMBLY__
+
+#endif // __ASSEMBLY__


Remove // ... or switch to /* ... */

lupyuen · 2024-12-14T02:44:06Z

arch/arm64/src/bcm2711/bcm2711_serial.h

+
+#endif // __ASSEMBLY__
+
+#endif // __ARCH_ARM64_SRC_BCM2711_BCM2711_SERIAL_H


lupyuen · 2024-12-14T02:44:35Z

arch/arm64/src/bcm2711/hardware/bcm2711_armtimer.h

+
+#define BCM_ARMT_PREDIV_PREDIV (0x3ff << 0)
+
+#endif // __ARCH_ARM64_SRC_BCM2711_ARMTIMER_H


Remove // ... or switch to /* ... */

lupyuen · 2024-12-14T02:48:58Z

boards/arm64/bcm2711/raspberrypi-4b/src/rpi4b_gpio.c

+
+static struct bcm2711_gpio_dev_s g_gpout[BOARD_NGPIOOUT];
+
+#endif // BOARD_NGPIOOUT > 0


Remove // ... or switch to /* ... */

lupyuen · 2024-12-14T02:49:06Z

boards/arm64/bcm2711/raspberrypi-4b/src/rpi4b_gpio.c

+
+static struct bcm2711_gpio_dev_s g_gpin[BOARD_NGPIOIN];
+
+#endif // BOARD_NGPIOIN > 0


Remove // ... or switch to /* ... */

lupyuen · 2024-12-14T02:49:16Z

boards/arm64/bcm2711/raspberrypi-4b/src/rpi4b_gpio.c

+
+static struct bcm2711_gpioint_dev_s g_gpint[BOARD_NGPIOINT];
+
+#endif // BOARD_NGPIOINT > 0


Remove // ... or switch to /* ... */

lupyuen · 2024-12-14T02:49:24Z

boards/arm64/bcm2711/raspberrypi-4b/src/rpi4b_gpio.c

+  return 0;
+}
+
+#endif // BOARD_NGPIOOUT > 0


Remove // ... or switch to /* ... */

lupyuen · 2024-12-14T02:49:31Z

boards/arm64/bcm2711/raspberrypi-4b/src/rpi4b_gpio.c

+  return 0;
+}
+
+#endif // BOARD_NGPIOIN > 0


Remove // ... or switch to /* ... */

raiden00pl · 2024-12-14T07:38:27Z

.gitignore

@@ -80,4 +82,6 @@ SAVEMake.defs
 SAVEconfig
 .aider*
 imx9-norimage.img
-
+config.txt
+tools/bcm2711/*.dat


move to tools/bcm2711/.gitignore

raiden00pl · 2024-12-14T07:41:23Z

arch/arm64/Kconfig

@@ -352,6 +366,7 @@ config ARM64_DECODEFIQ
 config ARM64_GIC_VERSION
 	int "GIC version"
 	default 2           if ARCH_CHIP_A64


wrong alignment, you can move this to the previous line default 2 if ARCH_CHIP_A64 | ARCH_CHIP_BCM2711

raiden00pl · 2024-12-14T07:44:39Z

arch/arm64/src/bcm2711/bcm2711_spi.c

+#include "chip.h"
+#include "hardware/bcm2711_aux.h"
+
+#define CONFIG_BCM2711_SPI // TODO remove


remove, we don't need this. It's already protected by if in Make.defs

linguini1 added 30 commits July 21, 2024 11:29

Ignore clangd and clang-format development artifacts.

18515e6

Auxiliary register definitions.

a8c41ac

Some register bit definitions.

d7b573a

Formatting.

f72f254

BCM2711 is 64 bit.

443fdac

BCM2711 is 64 bit.

4228e94

More bit definitions.

19dd471

Fix IIR interrupt ID definitions.

133cad4

All mini UART register definitions complete.

a947d04

Control 0 register of SPI bit definitions.

27652e9

Control 1 register for SPI bit definitions.

0dab0c2

Stat registers.

c5d7af0

Data masks. All SPI bit definitions done.

d0f1d75

I2C/BSC controller register definitions.

4b33eab

Typos resolved.

7f6f53c

DMA definitions mostly complete.

414a718

GPIO register addresses.

333b34f

Function select register masks

50646f5

Resistor control register bit definitions.

717448b

Leave note about function select in case it's necessary.

9252163

General purpose clock control

fae9011

IRQ definitions file.

984ab1d

Completed ARM_LOCAL registers and some ARMC

04ff26a

Finished ARMC interrupt register definitions.

06b39d1

Finished register definitions for PCM.

19bbc3e

PWM registers complete.

999dce3

Added all SPI register definitions.

13f9da0

System timer register definitions complete

9d387fb

UART interface register definitions complete.

bce2c4a

ARM timer register definitions complete.

bd46979

linguini1 added 14 commits October 23, 2024 18:48

Merge branch 'master' into bcm2711

1fcaedf

Fix merge issues

d15ef0f

Fix timer setup.

b41afa7

Better config.txt generation.

1419918

Auto-download boot files

a34685f

Update bootfiles script to properly download raw files.

ad06a4c

Fixed the config option to booth in arm64 mode. I had made a typo, wh…

1f69927

…ich selected the wrong boot option and caused the binary not to load. This made me lose my mind for at least one hour debugging.

Update documentation with SD card formatting instructions and an image.

692fcfa

Initial boiler plate for SPI interface driver.

b13813b

Updated RAM sizing selection. Has no effect on CONFIG_RAM_SIZE yet...…

e6bab92

… not sure how to best do that.

Infrastructure for SMP. Doesn't work still; only getting the initial …

fa3976a

…'----' of NSH before shell is unresponsive.

Merge branch 'master' into bcm2711

db8073e

All style issues resolved.

98f749b

Fixed up_putc definition so things compile

9c5c61e

acassis requested review from lupyuen, xiaoxiang781216, pussuw, raiden00pl and pkarashchenko December 13, 2024 21:54

lupyuen requested changes Dec 14, 2024

View reviewed changes

raiden00pl reviewed Dec 14, 2024

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add support for the BCM2711 #15188

Add support for the BCM2711 #15188

linguini1 commented Dec 13, 2024 •

edited

Loading

linguini1 commented Dec 13, 2024 •

edited

Loading

acassis commented Dec 13, 2024

lupyuen Dec 14, 2024

lupyuen Dec 14, 2024

lupyuen Dec 14, 2024

lupyuen Dec 14, 2024

lupyuen Dec 14, 2024

lupyuen Dec 14, 2024

lupyuen Dec 14, 2024

lupyuen Dec 14, 2024

lupyuen Dec 14, 2024

lupyuen Dec 14, 2024

raiden00pl Dec 14, 2024

raiden00pl Dec 14, 2024

raiden00pl Dec 14, 2024


		#endif // __ASSEMBLY__

		#endif // __ARCH_ARM64_SRC_BCM2711_BCM2711_SERIAL_H


		#define BCM_ARMT_PREDIV_PREDIV (0x3ff << 0)

		#endif // __ARCH_ARM64_SRC_BCM2711_ARMTIMER_H


		static struct bcm2711_gpio_dev_s g_gpout[BOARD_NGPIOOUT];

		#endif // BOARD_NGPIOOUT > 0


		static struct bcm2711_gpio_dev_s g_gpin[BOARD_NGPIOIN];

		#endif // BOARD_NGPIOIN > 0


		static struct bcm2711_gpioint_dev_s g_gpint[BOARD_NGPIOINT];

		#endif // BOARD_NGPIOINT > 0

Add support for the BCM2711 #15188

Are you sure you want to change the base?

Add support for the BCM2711 #15188

Conversation

linguini1 commented Dec 13, 2024 • edited Loading

Summary

Impact

Testing

linguini1 commented Dec 13, 2024 • edited Loading

acassis commented Dec 13, 2024

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

linguini1 commented Dec 13, 2024 •

edited

Loading

linguini1 commented Dec 13, 2024 •

edited

Loading