Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

risc-v: Move CSR register manipulation macros to csr.h #15164

Merged
merged 1 commit into from
Dec 12, 2024

Conversation

no1wudi
Copy link
Contributor

@no1wudi no1wudi commented Dec 12, 2024

Summary

This patch allow public arch level code use them, make it possible to access system register in common code, such as percpu.

Impact

RISC-V Only

Testing

GitHub CI and local machine

@github-actions github-actions bot added Arch: risc-v Issues related to the RISC-V (32-bit or 64-bit) architecture Size: M The size of the change in this PR is medium labels Dec 12, 2024
@nuttxpr
Copy link

nuttxpr commented Dec 12, 2024

[Experimental Bot, please feedback here]

No, this PR does not fully meet the NuttX requirements. The summary is insufficiently detailed. It doesn't explain why making system registers accessible in common code is necessary (what problem does it solve?). It vaguely mentions percpu, but doesn't explain how the change works or what specifically changes. It's missing links to related issues.

The Impact section lacks detail. While it specifies RISC-V, it doesn't describe the changes to the architecture/boards/drivers. It's missing information about documentation, security, compatibility, and "anything else to consider."

The Testing section is also inadequate. It mentions GitHub CI and a local machine, but provides no details about the host or target environments. Critically, it lacks "before" and "after" testing logs, making it impossible to verify the change's effectiveness.

This patch allow public arch level code use them, make it possible to access system register in common code, such as percpu.

Signed-off-by: Huang Qi <[email protected]>
@xiaoxiang781216 xiaoxiang781216 merged commit 4e9702c into apache:master Dec 12, 2024
16 of 17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Arch: risc-v Issues related to the RISC-V (32-bit or 64-bit) architecture Size: M The size of the change in this PR is medium
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants