Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

testing/nand_sim: Adds a virtual NAND Flash device #2319

Merged
merged 1 commit into from
Mar 21, 2024

Conversation

resyfer
Copy link
Contributor

@resyfer resyfer commented Feb 29, 2024

Adds NAND Flash device in simulator
Fixes echo in terminal for Vi

Summary

  • Adds a NAND Flash virtual device for the simulator.
  • Removes echo of commands in vi (especially during movement), and double echo of characters in command line in vi due to the same reason.

Impact

  • NAND flash compatible file systems can test using this.
  • Makes vi more usable

Testing

  • Basic file system operations after mounting using littlefs.
  • checkpatch.sh (An error that nxstyle gives, which looks to be a genuine error, is /nuttxspace/apps/testing/nand_sim/nand_sim_main.c:103:44: error: Multiple data definitions which might be in this issue).

.gitignore Show resolved Hide resolved
system/vi/vi.c Outdated Show resolved Hide resolved
system/vi/vi.c Outdated Show resolved Hide resolved
system/vi/vi.c Outdated Show resolved Hide resolved
testing/nand_sim/nand_sim.h Outdated Show resolved Hide resolved
testing/nand_sim/nand_sim_raw.c Outdated Show resolved Hide resolved
testing/nand_sim/nand_sim_wrapper.c Outdated Show resolved Hide resolved
@resyfer resyfer force-pushed the nand_sim branch 2 times, most recently from d0c3bc3 to e3a8575 Compare March 4, 2024 16:44
@resyfer resyfer requested a review from xiaoxiang781216 March 4, 2024 16:45
@acassis
Copy link
Contributor

acassis commented Mar 15, 2024

@xiaoxiang781216 @resyfer why the CI is failing? Should Saurav rebase it to force the CI to pass?

Adds a NAND virtual device daemon.

Signed-off-by: Saurav Pal <[email protected]>
@resyfer
Copy link
Contributor Author

resyfer commented Mar 16, 2024

@acassis Hi! Sorry for the late reply. I've done a force push.

What I don't understand is this line from the error (and subsequent lines similar to it):

/github/workspace/sources/apps/testing/nand_sim/Kconfig:34: 'endif' in different file than 'if'

I have them:

6  | config TESTING_NAND_SIM
...
12 | if TESTING_NAND_SIM
...
34 | endif

I had tried force pushing earlier after rebasing, but it still showed this CI error.

@resyfer
Copy link
Contributor Author

resyfer commented Mar 17, 2024

@acassis @xiaoxiang781216 Hi, can you please approve this PR for CI testing? Thank you!

@acassis
Copy link
Contributor

acassis commented Mar 17, 2024

Hi @resyfer sorry I missed your message. I don't look nuttx-apps so often as I do for nuttx kernel. I hope now it works fine

@resyfer
Copy link
Contributor Author

resyfer commented Mar 17, 2024

Hi @acassis no worries! Thanks for the approval. It also looks like the CI tests have completed finally.

@xiaoxiang781216 xiaoxiang781216 merged commit f409296 into apache:master Mar 21, 2024
25 checks passed
@resyfer
Copy link
Contributor Author

resyfer commented Mar 21, 2024

Thank you for the review!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants