[GLUTEN-8094][CH][Part-1] Support reading data from the iceberg with CH backend #8095
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…CH backend Support reading data from the iceberg with CH backend - basic iceberg scan transformer - read from the iceberg with the copy-on-write mode
|
Run Gluten Clickhouse CI on x86 |
zhztheplayer
approved these changes
Nov 29, 2024
| @@ -76,4 +76,7 @@ trait TransformerApi { | |||
| def invalidateSQLExecutionResource(executionId: String): Unit = {} | |||
|
|
|||
| def genWriteParameters(fileFormat: FileFormat, writeOptions: Map[String, String]): Any | |||
|
|
|||
| /** use Hadoop Path class to encode the file path */ | |||
| def encodeFilePathIfNeed(filePath: String): String = filePath | |||
There was a problem hiding this comment.
It turn out that a similar difference exists on regular scan
VL
CH
Maybe the logics should be somehow consolidated in future, I am not sure.
|
Run Gluten Clickhouse CI on x86 |
liujiayi771
reviewed
Nov 29, 2024
| import org.apache.spark.SparkConf | ||
| import org.apache.spark.sql.Row | ||
|
|
||
| class ClickHouseIcebergSuite extends GlutenClickHouseWholeStageTransformerSuite { |
There was a problem hiding this comment.
Is it possible to allow CH and Velox to share this part of the test cases?
There was a problem hiding this comment.
will share this part after the CH backend support the merge on read mode for the iceberg, and there is also a bug when using the timestamp type as partition column for the CH backend.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Support reading data from the iceberg with CH backend
How was this patch tested?
(Please explain how this patch was tested. E.g. unit tests, integration tests, manual tests)
(If this patch involves UI changes, please attach a screenshot; otherwise, remove this)