Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[VL] Incorporate SQL Union operator into Velox execution pipeline #7745

Open
zhztheplayer opened this issue Oct 31, 2024 · 4 comments
Open
Labels
enhancement New feature or request

Comments

@zhztheplayer
Copy link
Member

zhztheplayer commented Oct 31, 2024

Union is currently implemented in Java and the operator could break up one fused Velox's task into two. We'd find a way to offload the operator to Velox so Velox could get a bigger plan for applying more local optimizations.

@zhztheplayer zhztheplayer added the enhancement New feature or request label Oct 31, 2024
@FelixYBW
Copy link
Contributor

FelixYBW commented Nov 1, 2024

Have we observed any performance issue of the break?

@zhztheplayer
Copy link
Member Author

Have we observed any performance issue of the break?

There is no performance issue so far. The current implementation doesn't involve in any data copy yet.

@FelixYBW
Copy link
Contributor

FelixYBW commented Nov 7, 2024

We may lower its priority if so.

@zhztheplayer
Copy link
Member Author

I had a PoC at #7842. Union is comparatively special as it requires multiple Velox execution pipelines. Implementing it should help us on understanding and improving Velox's single threaded execution routine.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants