From f4e0ad21b6e3ebe3102f0cadc5c31f061b6f8ea0 Mon Sep 17 00:00:00 2001 From: Zachary Pinto Date: Wed, 1 Nov 2023 22:58:07 -0700 Subject: [PATCH] Fix condition to check if DOMAIN has all required TOPOLOGY keys and allows for extra kv pairs, to reduce noisy logs. --- .../apache/helix/controller/rebalancer/topology/Topology.java | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/helix-core/src/main/java/org/apache/helix/controller/rebalancer/topology/Topology.java b/helix-core/src/main/java/org/apache/helix/controller/rebalancer/topology/Topology.java index dba1201680..4d4ebabd11 100644 --- a/helix-core/src/main/java/org/apache/helix/controller/rebalancer/topology/Topology.java +++ b/helix-core/src/main/java/org/apache/helix/controller/rebalancer/topology/Topology.java @@ -233,7 +233,7 @@ private static LinkedHashMap computeInstanceTopologyMapHelper( return instanceTopologyMap; } } - if (numOfMatchedKeys != domainAsMap.size()) { + if (numOfMatchedKeys < clusterTopologyConfig.getTopologyKeyDefaultValue().size()) { logger.warn( "Key-value pairs in InstanceConfig.Domain {} do not align with keys in ClusterConfig.Topology " + "{}, using default domain value instead", instanceConfig.getDomainAsString(),