From 53121388677afc50c1c2fc80e22a47cd4675ea4f Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?S=C3=A9bastien?= Date: Thu, 19 Oct 2023 15:50:42 +0200 Subject: [PATCH 1/2] Proper default for taskLockType in streaming ingestion --- web-console/src/views/load-data-view/load-data-view.tsx | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/web-console/src/views/load-data-view/load-data-view.tsx b/web-console/src/views/load-data-view/load-data-view.tsx index 447a6379487b..e4560c68e801 100644 --- a/web-console/src/views/load-data-view/load-data-view.tsx +++ b/web-console/src/views/load-data-view/load-data-view.tsx @@ -3177,7 +3177,7 @@ export class LoadDataView extends React.PureComponent (v ? (appendToExisting ? 'APPEND' : 'REPLACE') : undefined), adjustValue: v => v === (appendToExisting ? 'APPEND' : 'REPLACE'), info:

Allows or forbids concurrent tasks.

, From 645bb6ed83db53f9b36e6cd146c8d1fa04cce93a Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?S=C3=A9bastien?= Date: Thu, 19 Oct 2023 16:20:22 +0200 Subject: [PATCH 2/2] fixup --- .../views/load-data-view/load-data-view.tsx | 22 ++++++++++++++++--- 1 file changed, 19 insertions(+), 3 deletions(-) diff --git a/web-console/src/views/load-data-view/load-data-view.tsx b/web-console/src/views/load-data-view/load-data-view.tsx index e4560c68e801..af39c2d0385b 100644 --- a/web-console/src/views/load-data-view/load-data-view.tsx +++ b/web-console/src/views/load-data-view/load-data-view.tsx @@ -3177,9 +3177,25 @@ export class LoadDataView extends React.PureComponent (v ? (appendToExisting ? 'APPEND' : 'REPLACE') : undefined), - adjustValue: v => v === (appendToExisting ? 'APPEND' : 'REPLACE'), + defaultValue: undefined, + valueAdjustment: v => { + if (!v) return undefined; + + if (isStreamingSpec(spec)) { + return 'APPEND'; + } else { + return appendToExisting ? 'APPEND' : 'REPLACE'; + } + }, + adjustValue: v => { + if (v === undefined) return false; + + if (isStreamingSpec(spec)) { + return v === 'APPEND'; + } + + return v === (appendToExisting ? 'APPEND' : 'REPLACE'); + }, info:

Allows or forbids concurrent tasks.

, }, ]}