From 12ec5c3a4d2d18aa7cc7863a44ccb5662eacd317 Mon Sep 17 00:00:00 2001
From: Lee Rhodes <leerho@gmail.com>
Date: Wed, 18 Dec 2024 19:09:06 -0800
Subject: [PATCH 01/10] fix indentations in all workflows

---
 .github/workflows/auto-check_cpp_files.yml   |   3 +-
 .github/workflows/auto-jdk-matrix.yml        |  96 ++++++++--------
 .github/workflows/auto-os-matrix.yml         | 114 +++++++++----------
 .github/workflows/manual-codeql-analysis.yml |  70 ++++++------
 .github/workflows/manual-javadoc.yml         |   2 +-
 5 files changed, 143 insertions(+), 142 deletions(-)

diff --git a/.github/workflows/auto-check_cpp_files.yml b/.github/workflows/auto-check_cpp_files.yml
index 068b12f4d..858e760fb 100644
--- a/.github/workflows/auto-check_cpp_files.yml
+++ b/.github/workflows/auto-check_cpp_files.yml
@@ -1,8 +1,9 @@
 name: Serialization Compatibility Test
 
 on:
+  pull_request:
   push:
-    branches: [ master, main ]
+    branches: [ 7.0.X ]
   workflow_dispatch:
 
 jobs:
diff --git a/.github/workflows/auto-jdk-matrix.yml b/.github/workflows/auto-jdk-matrix.yml
index f8220bbe2..49be43018 100644
--- a/.github/workflows/auto-jdk-matrix.yml
+++ b/.github/workflows/auto-jdk-matrix.yml
@@ -1,67 +1,67 @@
 name: DataSketches-Java Auto JDK Matrix Test & Install
 
 on:
-    pull_request:
-    push:
-        branches: [ master, main ]
-    workflow_dispatch:
+  pull_request:
+  push:
+    branches: [ 7.0.X ]
+  workflow_dispatch:
 
 env:
-    MAVEN_OPTS: -Xmx4g -Xms1g
+  MAVEN_OPTS: -Xmx4g -Xms1g
 
 jobs:
-    build:
-        name: Build, Test, Install
-        runs-on: ubuntu-latest
+  build:
+    name: Build, Test, Install
+    runs-on: ubuntu-latest
 
-        strategy:
-          fail-fast: false
-          matrix:
-              jdk: [ 17 ]
+    strategy:
+      fail-fast: false
+      matrix:
+        jdk: [ 17 ]
 
-        env:
-          JDK_VERSION: ${{ matrix.jdk }}
+    env:
+      JDK_VERSION: ${{ matrix.jdk }}
 
-        steps:
-        - name: "Checkout ${{ github.ref }} ( ${{ github.sha }} )"
-          uses: actions/checkout@v4
-          with:
-              persist-credentials: false
+    steps:
+      - name: "Checkout ${{ github.ref }} ( ${{ github.sha }} )"
+        uses: actions/checkout@v4
+        with:
+          persist-credentials: false
 
-        - name: Print Current workflow
-          run: >
-             cat .github/workflows/auto-jdk-matrix.yml
+      - name: Print Current workflow
+        run: >
+          cat .github/workflows/auto-jdk-matrix.yml
 
-        - name: Cache local Maven repository
-          uses: actions/cache@v4
-          with:
-              path: ~/.m2/repository
-              key: build-${{ runner.os }}-maven-${{ hashFiles('**/pom.xml') }}
-              restore-keys: build-${{ runner.os }}-maven-
+      - name: Cache local Maven repository
+        uses: actions/cache@v4
+        with:
+          path: ~/.m2/repository
+          key: build-${{ runner.os }}-maven-${{ hashFiles('**/pom.xml') }}
+          restore-keys: build-${{ runner.os }}-maven-
 
-        - name: Install Matrix JDK
-          uses: actions/setup-java@v4
-          with:
-              java-version: ${{ matrix.jdk }}
-              distribution: 'temurin'
-              java-package: jdk
-              architecture: x64 
+      - name: Install Matrix JDK
+        uses: actions/setup-java@v4
+        with:
+          java-version: ${{ matrix.jdk }}
+          distribution: 'temurin'
+          java-package: jdk
+          architecture: x64 
 
-        - name: Echo Java Version
-          run: >
-              java -version
+      - name: Echo Java Version
+        run: >
+          java -version
 
-        - name: Test
-          run: >
-              mvn clean test -B
-              -Dmaven.javadoc.skip=true
-              -Dgpg.skip=true
+      - name: Test
+        run: >
+          mvn clean test -B
+          -Dmaven.javadoc.skip=true
+          -Dgpg.skip=true
 
-        - name: Install
-          run: >
-              mvn clean install -B
-              -DskipTests=true
-              -Dgpg.skip=true
+      - name: Install
+        run: >
+          mvn clean install -B
+          -DskipTests=true
+          -Dgpg.skip=true
 
 # Architecture options: x86, x64, armv7, aarch64, ppc64le
 # setup-java@v4 has a "with cache" option
diff --git a/.github/workflows/auto-os-matrix.yml b/.github/workflows/auto-os-matrix.yml
index d9f5bc4c5..b7d703a08 100644
--- a/.github/workflows/auto-os-matrix.yml
+++ b/.github/workflows/auto-os-matrix.yml
@@ -1,77 +1,77 @@
 name: DataSketches-Java Auto OS Matrix Test & Install
 
 on:
-    pull_request:
-    push:
-        branches: [ master, main ]
-    workflow_dispatch:
+  pull_request:
+  push:
+    branches: [ 7.0.X ]
+  workflow_dispatch:
 
 env:
-    MAVEN_OPTS: -Xmx1g -Xms1g
+  MAVEN_OPTS: -Xmx1g -Xms1g
 
 jobs:
-    build:
-        name: Build, Test, Install
+  build:
+    name: Build, Test, Install
 
-        strategy:
-          fail-fast: false
+    strategy:
+      fail-fast: false
 
-          matrix:
-            jdk: [ 17 ]
-            os: [ windows-latest, ubuntu-latest, macos-latest ]
-            include:
-              - os: windows-latest
-                skip_javadoc: "`-Dmaven`.javadoc`.skip=true"
-                skip_gpg: "`-Dgpg`.skip=true"
-              - os: ubuntu-latest
-                skip_javadoc: -Dmaven.javadoc.skip=true
-                skip_gpg: -Dgpg.skip=true
-              - os: macos-latest
-                skip_javadoc: -Dmaven.javadoc.skip=true
-                skip_gpg: -Dgpg.skip=true
+      matrix:
+        jdk: [ 17 ]
+        os: [ windows-latest, ubuntu-latest, macos-latest ]
+        include:
+          - os: windows-latest
+            skip_javadoc: "`-Dmaven`.javadoc`.skip=true"
+            skip_gpg: "`-Dgpg`.skip=true"
+          - os: ubuntu-latest
+            skip_javadoc: -Dmaven.javadoc.skip=true
+            skip_gpg: -Dgpg.skip=true
+          - os: macos-latest
+            skip_javadoc: -Dmaven.javadoc.skip=true
+            skip_gpg: -Dgpg.skip=true
 
-        runs-on: ${{matrix.os}}
+    runs-on: ${{matrix.os}}
 
-        env:
-          JDK_VERSION: ${{ matrix.jdk }}
+    env:
+      JDK_VERSION: ${{ matrix.jdk }}
 
-        steps:
-        - name: "Checkout ${{ github.ref }} ( ${{ github.sha }} )"
-          uses: actions/checkout@v4
-          with:
-              persist-credentials: false
+    steps:
+      - name: "Checkout ${{ github.ref }} ( ${{ github.sha }} )"
+        uses: actions/checkout@v4
+        with:
+          persist-credentials: false
 
-        - name: Cache local Maven repository
-          uses: actions/cache@v4
-          with:
-              path: ~/.m2/repository
-              key: build-${{ runner.os }}-maven-${{ hashFiles('**/pom.xml') }}
-              restore-keys: build-${{ runner.os }}-maven-
+      - name: Cache local Maven repository
+        uses: actions/cache@v4
+        with:
+          path: ~/.m2/repository
+          key: build-${{ runner.os }}-maven-${{ hashFiles('**/pom.xml') }}
+          restore-keys: build-${{ runner.os }}-maven-
 
-        - name: Install Matrix JDK
-          uses: actions/setup-java@v4
-          with:
-              java-version: ${{ matrix.jdk }}
-              distribution: 'temurin'
-              java-package: jdk
-              architecture: x64 
+      - name: Install Matrix JDK
+        uses: actions/setup-java@v4
+        with:
+          java-version: ${{ matrix.jdk }}
+          distribution: 'temurin'
+          java-package: jdk
+          architecture: x64 
 
-        - name: Echo Java Version
-          run: >
-              java -version
+      - name: Echo Java Version
+        run: >
+          java -version
 
-        - name: Test
-          run: >
-              mvn clean test
-              ${{matrix.os.skip_javadoc}}
-              ${{matrix.os.skip_gpg}}
+      - name: Test
+        run: >
+          mvn clean test
+          ${{matrix.os.skip_javadoc}}
+          ${{matrix.os.skip_gpg}}
 
-        - name: Install
-          run: >
-              mvn clean install -B
-              ${{matrix.os.skip_javadoc}}
-              -D skipTests=true
-              ${{matrix.os.skip_gpg}}
+      - name: Install
+        run: >
+          mvn clean install -B
+          ${{matrix.os.skip_javadoc}}
+          -D skipTests=true
+          ${{matrix.os.skip_gpg}}
 
 # Architecture options: x86, x64, armv7, aarch64, ppc64le
 # setup-java@v4 has a "with cache" option
diff --git a/.github/workflows/manual-codeql-analysis.yml b/.github/workflows/manual-codeql-analysis.yml
index 1b94d13a3..a68d4cfff 100644
--- a/.github/workflows/manual-codeql-analysis.yml
+++ b/.github/workflows/manual-codeql-analysis.yml
@@ -20,38 +20,38 @@ jobs:
         # Learn more about CodeQL language support at https://aka.ms/codeql-docs/language-support
 
     steps:
-    - name: Checkout repository
-      uses: actions/checkout@v4
-
-    # Initializes the CodeQL tools for scanning.
-    - name: Initialize CodeQL
-      uses: github/codeql-action/init@v4
-      with:
-        languages: ${{ matrix.language }}
-        # If you wish to specify custom queries, you can do so here or in a config file.
-        # By default, queries listed here will override any specified in a config file.
-        # Prefix the list here with "+" to use these queries and those in the config file.
-        
-        # Details on CodeQL's query packs refer to : https://docs.github.com/en/code-security/code-scanning/automatically-scanning-your-code-for-vulnerabilities-and-errors/configuring-code-scanning#using-queries-in-ql-packs
-        queries: +security-and-quality
-
-        
-    # Autobuild attempts to build any compiled languages  (C/C++, C#, Go, or Java).
-    # If this step fails, then you should remove it and run the build manually (see below)
-    - name: Autobuild
-      uses: github/codeql-action/autobuild@v4
-
-    #   Command-line programs to run using the OS shell.
-    #   See https://docs.github.com/en/actions/using-workflows/workflow-syntax-for-github-actions#jobsjob_idstepsrun
-
-    #   If the Autobuild fails above, remove it and uncomment the following three lines. 
-    #   modify them (or add more) to build your code if your project, please refer to the EXAMPLE below for guidance.
-
-    # - run: |
-    #   echo "Run, Build Application using script"
-    #   ./location_of_script_within_repo/buildscript.sh
-
-    - name: Perform CodeQL Analysis
-      uses: github/codeql-action/analyze@v4
-      with:
-        category: "/language:${{matrix.language}}"
+      - name: Checkout repository
+        uses: actions/checkout@v4
+
+      # Initializes the CodeQL tools for scanning.
+      - name: Initialize CodeQL
+        uses: github/codeql-action/init@v4
+        with:
+          languages: ${{ matrix.language }}
+          # If you wish to specify custom queries, you can do so here or in a config file.
+          # By default, queries listed here will override any specified in a config file.
+          # Prefix the list here with "+" to use these queries and those in the config file.
+          
+          # Details on CodeQL's query packs refer to : https://docs.github.com/en/code-security/code-scanning/automatically-scanning-your-code-for-vulnerabilities-and-errors/configuring-code-scanning#using-queries-in-ql-packs
+          queries: +security-and-quality
+
+          
+      # Autobuild attempts to build any compiled languages  (C/C++, C#, Go, or Java).
+      # If this step fails, then you should remove it and run the build manually (see below)
+      - name: Autobuild
+        uses: github/codeql-action/autobuild@v4
+
+      #   Command-line programs to run using the OS shell.
+      #   See https://docs.github.com/en/actions/using-workflows/workflow-syntax-for-github-actions#jobsjob_idstepsrun
+
+      #   If the Autobuild fails above, remove it and uncomment the following three lines. 
+      #   modify them (or add more) to build your code if your project, please refer to the EXAMPLE below for guidance.
+
+      # - run: |
+      #   echo "Run, Build Application using script"
+      #   ./location_of_script_within_repo/buildscript.sh
+
+      - name: Perform CodeQL Analysis
+        uses: github/codeql-action/analyze@v4
+        with:
+          category: "/language:${{matrix.language}}"
diff --git a/.github/workflows/manual-javadoc.yml b/.github/workflows/manual-javadoc.yml
index e65824e7e..dfcfb1152 100644
--- a/.github/workflows/manual-javadoc.yml
+++ b/.github/workflows/manual-javadoc.yml
@@ -22,7 +22,7 @@ jobs:
 
       - name: Print Current workflow
         run: >
-         cat .github/workflows/manual-javadoc.yml
+          cat .github/workflows/manual-javadoc.yml
 
       - name: Generate JavaDoc
         run: mvn clean javadoc:javadoc

From 7a4b6868d593a294a96f5d9dd90f4bb1485e8806 Mon Sep 17 00:00:00 2001
From: Lee Rhodes <leerho@gmail.com>
Date: Thu, 19 Dec 2024 09:00:25 -0800
Subject: [PATCH 02/10] Try to fix CodeQL workflow

---
 .github/workflows/manual-codeql-analysis.yml | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/.github/workflows/manual-codeql-analysis.yml b/.github/workflows/manual-codeql-analysis.yml
index a68d4cfff..54eb56f89 100644
--- a/.github/workflows/manual-codeql-analysis.yml
+++ b/.github/workflows/manual-codeql-analysis.yml
@@ -25,7 +25,7 @@ jobs:
 
       # Initializes the CodeQL tools for scanning.
       - name: Initialize CodeQL
-        uses: github/codeql-action/init@v4
+        uses: github/codeql-action/init@v3
         with:
           languages: ${{ matrix.language }}
           # If you wish to specify custom queries, you can do so here or in a config file.
@@ -39,7 +39,7 @@ jobs:
       # Autobuild attempts to build any compiled languages  (C/C++, C#, Go, or Java).
       # If this step fails, then you should remove it and run the build manually (see below)
       - name: Autobuild
-        uses: github/codeql-action/autobuild@v4
+        uses: github/codeql-action/autobuild@v3
 
       #   Command-line programs to run using the OS shell.
       #   See https://docs.github.com/en/actions/using-workflows/workflow-syntax-for-github-actions#jobsjob_idstepsrun
@@ -52,6 +52,6 @@ jobs:
       #   ./location_of_script_within_repo/buildscript.sh
 
       - name: Perform CodeQL Analysis
-        uses: github/codeql-action/analyze@v4
+        uses: github/codeql-action/analyze@v3
         with:
           category: "/language:${{matrix.language}}"

From c0fcb55045ce210fce4f6dd44e3e1ecaf56ec9f3 Mon Sep 17 00:00:00 2001
From: Lee Rhodes <leerho@gmail.com>
Date: Thu, 19 Dec 2024 11:21:52 -0800
Subject: [PATCH 03/10] Modify CodeQL with manual java build. Hopefully this
 will work.

Updated Checkstyle configuration, adding more comments and removing
unused modules.
---
 .github/workflows/manual-codeql-analysis.yml | 15 +++++-
 tools/CloverConfig.txt                       | 50 --------------------
 tools/SketchesCheckstyle.xml                 | 15 +++---
 tools/suppressions.xml                       | 29 ------------
 4 files changed, 19 insertions(+), 90 deletions(-)
 delete mode 100644 tools/CloverConfig.txt
 delete mode 100644 tools/suppressions.xml

diff --git a/.github/workflows/manual-codeql-analysis.yml b/.github/workflows/manual-codeql-analysis.yml
index 54eb56f89..b428865d0 100644
--- a/.github/workflows/manual-codeql-analysis.yml
+++ b/.github/workflows/manual-codeql-analysis.yml
@@ -38,8 +38,9 @@ jobs:
           
       # Autobuild attempts to build any compiled languages  (C/C++, C#, Go, or Java).
       # If this step fails, then you should remove it and run the build manually (see below)
-      - name: Autobuild
-        uses: github/codeql-action/autobuild@v3
+
+      # -name: Autobuild
+      #  uses: github/codeql-action/autobuild@v3
 
       #   Command-line programs to run using the OS shell.
       #   See https://docs.github.com/en/actions/using-workflows/workflow-syntax-for-github-actions#jobsjob_idstepsrun
@@ -51,6 +52,16 @@ jobs:
       #   echo "Run, Build Application using script"
       #   ./location_of_script_within_repo/buildscript.sh
 
+      # Note: Autobuild fails thus the following manual build
+      - name: Manual Build With Java 17
+        uses: actions/setup-java@v4
+          with:
+            java-version: '17'
+            distribution: 'temurin'
+
+      - name: Java Compile
+        run:  mvn clean compile
+
       - name: Perform CodeQL Analysis
         uses: github/codeql-action/analyze@v3
         with:
diff --git a/tools/CloverConfig.txt b/tools/CloverConfig.txt
deleted file mode 100644
index 845fede8c..000000000
--- a/tools/CloverConfig.txt
+++ /dev/null
@@ -1,50 +0,0 @@
-# Licensed to the Apache Software Foundation (ASF) under one
-# or more contributor license agreements.  See the NOTICE file
-# distributed with this work for additional information
-# regarding copyright ownership.  The ASF licenses this file
-# to you under the Apache License, Version 2.0 (the
-# "License"); you may not use this file except in compliance
-# with the License.  You may obtain a copy of the License at
-# 
-#   http://www.apache.org/licenses/LICENSE-2.0
-# 
-# Unless required by applicable law or agreed to in writing,
-# software distributed under the License is distributed on an
-# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
-# KIND, either express or implied.  See the License for the
-# specific language governing permissions and limitations
-# under the License.
-
-Clover Config for Eclipse:
-
-At Project Level Properties:
-Clover:
-	Instrumentation:
-		Initstring: Default value
-		Output Folder: ...project output dir(s)
-		Flush Policy: At JVM shutdown ...
-		Misc: Fully qualify ... , Instrument and compile at statement level
-	Contexts:
-		Check: assert statements
-		Add Custom Coverage Context Filter:
-			private-constructor: also see link below
-				Method
-				(.* )?private +[a-zA-Z0-9_$]+ *\( *\).*
-	Source Files
-		Only look ...
-			[check] src/main/java[includes=**/*.java][excludes=]
-			[check] src/test/java[includes=**/*.java][excludes=]
-	Test Classes
-		Assume all source in the specified folders are tests or test utility classes
-			[check] src/test/java
-
-At Clover "down-triangle" menu:
-	Columns:
-		Element
-		% TOTAL Coverage
-		Uncovered Elements: Custom: %UncoveredElements * TotalElements / 100
-		Total Elements
-
-
-
-http://alexruizlog.blogspot.com/2009/04/how-to-make-clover-ignore-private_21.html
\ No newline at end of file
diff --git a/tools/SketchesCheckstyle.xml b/tools/SketchesCheckstyle.xml
index 184a05ad3..53726a2c1 100644
--- a/tools/SketchesCheckstyle.xml
+++ b/tools/SketchesCheckstyle.xml
@@ -49,10 +49,12 @@ under the License.
     <property name="fileNamePattern" value=".*[\\/]src[\\/]test[\\/].*$"/>
   </module>
 
+  <!-- flag the first instance of a tab character in each java, xml, yml or yaml file -->
   <module name="FileTabCharacter">
-    <property name="eachLine" value="true"/>
+    <property name="fileExtensions" value="java, xml, yml, yaml"/>
   </module>
   
+  <!-- each package must have a package-info.java file -->
   <module name="JavadocPackage"/>
   
   <module name="NewlineAtEndOfFile">
@@ -67,6 +69,7 @@ under the License.
     <!-- <metadata name="net.sf.eclipsecs.core.lastEnabledSeverity" value="inherit"/> -->
   </module>
   
+  <!-- Filters -->
   <module name="SuppressWithPlainTextCommentFilter">
     <property name="offCommentFormat" value="//CHECKSTYLE.OFF\: ([\w\|]+)"/>
     <property name="onCommentFormat" value="//CHECKSTYLE.ON\: ([\w\|]+)"/>
@@ -80,13 +83,6 @@ under the License.
     <!-- Be able to ignore violations with @SuppressWarnings -->
     <!-- See https://checkstyle.org/filters/suppresswarningsfilter.html -->
     <module name="SuppressWarningsHolder"/>
-  
-    <!--
-      <module name="SuppressionFilter">
-      <property name="file" value="basedir/tools/suppressions.xml"/>
-      <property name="optional" value="false"/>
-      </module>
-    -->
 
     <!-- Annotations -->
     <module name="AnnotationLocation">
@@ -230,7 +226,8 @@ under the License.
       <property name="allowedAnnotations" value="Override, Test"/>
     </module>
     
-    <!-- <module name="JavadocParagraph"/> disabled because of a Checkstyle bug with <p> after @param -->
+    <!-- disabled because of a Checkstyle bug with <p> after @param -->
+    <!-- <module name="JavadocParagraph"/>  -->
 
     <module name="JavadocTagContinuationIndentation">
       <property name="severity" value="ignore"/>
diff --git a/tools/suppressions.xml b/tools/suppressions.xml
deleted file mode 100644
index 91b8833c4..000000000
--- a/tools/suppressions.xml
+++ /dev/null
@@ -1,29 +0,0 @@
-<?xml version="1.0"?>
-
-<!DOCTYPE suppressions PUBLIC
-  "-//Checkstyle//DTD SuppressionFilter Configuration 1.2//EN"
-  "https://checkstyle.org/dtds/suppressions_1_2.dtd">
-
-  <!--
-  Licensed to the Apache Software Foundation (ASF) under one
-  or more contributor license agreements.  See the NOTICE file
-  distributed with this work for additional information
-  regarding copyright ownership.  The ASF licenses this file
-  to you under the Apache License, Version 2.0 (the
-  "License"); you may not use this file except in compliance
-  with the License.  You may obtain a copy of the License at
-
-    http://www.apache.org/licenses/LICENSE-2.0
-
-  Unless required by applicable law or agreed to in writing,
-  software distributed under the License is distributed on an
-  "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
-  KIND, either express or implied.  See the License for the
-  specific language governing permissions and limitations
-  under the License.
-  -->
-
-<suppressions>
-  <suppress checks="Javadoc" files=".*[\\/]src[\\/](test|it)[\\/]"/>
-  <suppress checks="MagicNumber" files=".*[\\/]src[\\/](test|it)[\\/]"/>
-</suppressions>
\ No newline at end of file

From 55f1d5622aa411744a15f1c28ca9872ba8b0ac0b Mon Sep 17 00:00:00 2001
From: Lee Rhodes <leerho@gmail.com>
Date: Thu, 19 Dec 2024 11:35:28 -0800
Subject: [PATCH 04/10] Update workflow names to make them more identifiable

---
 .github/workflows/auto-check_cpp_files.yml   | 2 +-
 .github/workflows/auto-jdk-matrix.yml        | 2 +-
 .github/workflows/auto-os-matrix.yml         | 2 +-
 .github/workflows/manual-codeql-analysis.yml | 2 +-
 .github/workflows/manual-javadoc.yml         | 2 +-
 5 files changed, 5 insertions(+), 5 deletions(-)

diff --git a/.github/workflows/auto-check_cpp_files.yml b/.github/workflows/auto-check_cpp_files.yml
index 858e760fb..9e577d71c 100644
--- a/.github/workflows/auto-check_cpp_files.yml
+++ b/.github/workflows/auto-check_cpp_files.yml
@@ -1,4 +1,4 @@
-name: Serialization Compatibility Test
+name: C++ Serialization Compatibility Test
 
 on:
   pull_request:
diff --git a/.github/workflows/auto-jdk-matrix.yml b/.github/workflows/auto-jdk-matrix.yml
index 49be43018..873ce59f6 100644
--- a/.github/workflows/auto-jdk-matrix.yml
+++ b/.github/workflows/auto-jdk-matrix.yml
@@ -1,4 +1,4 @@
-name: DataSketches-Java Auto JDK Matrix Test & Install
+name: Auto JDK Matrix Test, Install
 
 on:
   pull_request:
diff --git a/.github/workflows/auto-os-matrix.yml b/.github/workflows/auto-os-matrix.yml
index b7d703a08..473211f67 100644
--- a/.github/workflows/auto-os-matrix.yml
+++ b/.github/workflows/auto-os-matrix.yml
@@ -1,4 +1,4 @@
-name: DataSketches-Java Auto OS Matrix Test & Install
+name: Auto OS Matrix Test, Install
 
 on:
   pull_request:
diff --git a/.github/workflows/manual-codeql-analysis.yml b/.github/workflows/manual-codeql-analysis.yml
index b428865d0..a05e5696d 100644
--- a/.github/workflows/manual-codeql-analysis.yml
+++ b/.github/workflows/manual-codeql-analysis.yml
@@ -1,4 +1,4 @@
-name: "CodeQL"
+name: "CodeQL Analysis"
 
 on:
   workflow_dispatch:
diff --git a/.github/workflows/manual-javadoc.yml b/.github/workflows/manual-javadoc.yml
index dfcfb1152..7358cc3de 100644
--- a/.github/workflows/manual-javadoc.yml
+++ b/.github/workflows/manual-javadoc.yml
@@ -1,4 +1,4 @@
-name: JavaDoc
+name: Publish JavaDoc
 
 on:
   workflow_dispatch:

From 6b85284e63501f214b78ffd87c3deeed4e07f5dd Mon Sep 17 00:00:00 2001
From: Lee Rhodes <leerho@gmail.com>
Date: Thu, 19 Dec 2024 11:46:01 -0800
Subject: [PATCH 05/10] Name must not be quoted

---
 .github/workflows/auto-check_cpp_files.yml   | 2 +-
 .github/workflows/manual-codeql-analysis.yml | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/.github/workflows/auto-check_cpp_files.yml b/.github/workflows/auto-check_cpp_files.yml
index 9e577d71c..f80403e53 100644
--- a/.github/workflows/auto-check_cpp_files.yml
+++ b/.github/workflows/auto-check_cpp_files.yml
@@ -1,4 +1,4 @@
-name: C++ Serialization Compatibility Test
+name: Auto C++ Serialization Compatibility Test
 
 on:
   pull_request:
diff --git a/.github/workflows/manual-codeql-analysis.yml b/.github/workflows/manual-codeql-analysis.yml
index a05e5696d..5ed7b46a9 100644
--- a/.github/workflows/manual-codeql-analysis.yml
+++ b/.github/workflows/manual-codeql-analysis.yml
@@ -1,4 +1,4 @@
-name: "CodeQL Analysis"
+name: Manual CodeQL Analysis
 
 on:
   workflow_dispatch:

From 401b1fb47c6e419fb0578d6351e01869b7ef8c6e Mon Sep 17 00:00:00 2001
From: Lee Rhodes <leerho@gmail.com>
Date: Thu, 19 Dec 2024 11:58:29 -0800
Subject: [PATCH 06/10] Make all workflows auto so they show up for testing.

---
 .github/workflows/manual-codeql-analysis.yml | 3 +++
 .github/workflows/manual-javadoc.yml         | 3 +++
 2 files changed, 6 insertions(+)

diff --git a/.github/workflows/manual-codeql-analysis.yml b/.github/workflows/manual-codeql-analysis.yml
index 5ed7b46a9..9e7110454 100644
--- a/.github/workflows/manual-codeql-analysis.yml
+++ b/.github/workflows/manual-codeql-analysis.yml
@@ -1,6 +1,9 @@
 name: Manual CodeQL Analysis
 
 on:
+  pull_request:
+  push:
+    branches: [ 7.0.X ]
   workflow_dispatch:
 
 jobs:
diff --git a/.github/workflows/manual-javadoc.yml b/.github/workflows/manual-javadoc.yml
index 7358cc3de..f1cd56e75 100644
--- a/.github/workflows/manual-javadoc.yml
+++ b/.github/workflows/manual-javadoc.yml
@@ -1,6 +1,9 @@
 name: Publish JavaDoc
 
 on:
+  pull_request:
+  push:
+    branches: [ 7.0.X ]
   workflow_dispatch:
 
 jobs:

From e264d3ff8d734ca498c9411a1730bdcefe4627c1 Mon Sep 17 00:00:00 2001
From: Lee Rhodes <leerho@gmail.com>
Date: Thu, 19 Dec 2024 12:11:02 -0800
Subject: [PATCH 07/10] revert workfile name and yml file name to what they
 were before.

---
 .../{manual-codeql-analysis.yml => codeql-analysis.yml}     | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)
 rename .github/workflows/{manual-codeql-analysis.yml => codeql-analysis.yml} (97%)

diff --git a/.github/workflows/manual-codeql-analysis.yml b/.github/workflows/codeql-analysis.yml
similarity index 97%
rename from .github/workflows/manual-codeql-analysis.yml
rename to .github/workflows/codeql-analysis.yml
index 9e7110454..aaceefd82 100644
--- a/.github/workflows/manual-codeql-analysis.yml
+++ b/.github/workflows/codeql-analysis.yml
@@ -1,10 +1,10 @@
-name: Manual CodeQL Analysis
+name: "CodeQL"
 
 on:
-  pull_request:
   push:
     branches: [ 7.0.X ]
-  workflow_dispatch:
+	pull_request: [ 7.0.X ]
+	workflow_dispatch:
 
 jobs:
   analyze:

From eb5fe28a663b42eac5ef3c02542a7d6d6128e057 Mon Sep 17 00:00:00 2001
From: Lee Rhodes <leerho@gmail.com>
Date: Thu, 19 Dec 2024 12:13:44 -0800
Subject: [PATCH 08/10] Fix indent on codeql-analysis

---
 .github/workflows/codeql-analysis.yml | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/.github/workflows/codeql-analysis.yml b/.github/workflows/codeql-analysis.yml
index aaceefd82..230bd8f8e 100644
--- a/.github/workflows/codeql-analysis.yml
+++ b/.github/workflows/codeql-analysis.yml
@@ -3,8 +3,8 @@ name: "CodeQL"
 on:
   push:
     branches: [ 7.0.X ]
-	pull_request: [ 7.0.X ]
-	workflow_dispatch:
+  pull_request: [ 7.0.X ]
+  workflow_dispatch:
 
 jobs:
   analyze:

From de840df7f5b032ac48b477e0d7b2f00f92e3973f Mon Sep 17 00:00:00 2001
From: Lee Rhodes <leerho@gmail.com>
Date: Thu, 19 Dec 2024 12:27:44 -0800
Subject: [PATCH 09/10] fix indent

---
 .github/workflows/codeql-analysis.yml | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/.github/workflows/codeql-analysis.yml b/.github/workflows/codeql-analysis.yml
index 230bd8f8e..cf1cc9d7f 100644
--- a/.github/workflows/codeql-analysis.yml
+++ b/.github/workflows/codeql-analysis.yml
@@ -58,9 +58,9 @@ jobs:
       # Note: Autobuild fails thus the following manual build
       - name: Manual Build With Java 17
         uses: actions/setup-java@v4
-          with:
-            java-version: '17'
-            distribution: 'temurin'
+        with:
+          java-version: '17'
+          distribution: 'temurin'
 
       - name: Java Compile
         run:  mvn clean compile

From ef3310db8644e22cb00ed52ea347fd303c0da355 Mon Sep 17 00:00:00 2001
From: Lee Rhodes <leerho@gmail.com>
Date: Thu, 19 Dec 2024 14:05:29 -0800
Subject: [PATCH 10/10] Trying codeql again.

---
 .github/workflows/codeql-analysis.yml | 11 +++++++++--
 1 file changed, 9 insertions(+), 2 deletions(-)

diff --git a/.github/workflows/codeql-analysis.yml b/.github/workflows/codeql-analysis.yml
index cf1cc9d7f..427faa7cd 100644
--- a/.github/workflows/codeql-analysis.yml
+++ b/.github/workflows/codeql-analysis.yml
@@ -2,8 +2,15 @@ name: "CodeQL"
 
 on:
   push:
-    branches: [ 7.0.X ]
-  pull_request: [ 7.0.X ]
+    branches:
+      - '7.0.X'
+      - 'main'
+  pull_request_target:
+    types:
+      - opened
+    branches:
+      - '7.0.X'
+      - 'main'
   workflow_dispatch:
 
 jobs: