Error when use user field in where caluse

[haohuaijin]

Describe the bug

DataFusion CLI v44.0.0
> create table t(a int, b int, user text) as values (1,2,'test'), (2,3,null);
0 row(s) fetched.
Elapsed 0.051 seconds.

> select * from t;
+---+---+------+
| a | b | user |
+---+---+------+
| 1 | 2 | test |
| 2 | 3 |      |
+---+---+------+
2 row(s) fetched.
Elapsed 0.006 seconds.

> select * from t where user = 'test';
Error during planning: Invalid function 'user'.
Did you mean 'upper'?

To Reproduce

like above

Expected behavior

this query can run success

Additional context

test in datafusion v44.0.0, v43.0.0 and current main, both reported error
not sure if it is a bug or user is a keyword, but i also check in duckdb, it work

D create table t(a int, b int, user text); insert into t values (1,2,'test'), (2,3,null);
D select * from t where user = 'test';
┌───────┬───────┬─────────┐
│   a   │   b   │  user   │
│ int32 │ int32 │ varchar │
├───────┼───────┼─────────┤
│     1 │     2 │ test    │
└───────┴───────┴─────────┘
D

[chenkovsky]

it seems that it's sqlparser parsing error. I created an issue apache/datafusion-sqlparser-rs#1658

[alamb]

I think you can work around it by enclosing user in double quotes:

select * from t where "user" = 'test';

[chenkovsky]

I try to make genericdialect more customizable, but it seems that it maybe not a good idea. ಥ_ಥ

[alamb]

I try to make genericdialect more customizable, but it seems that it maybe not a good idea. ಥ_ಥ

Note there is:
https://datafusion.apache.org/user-guide/configs.html

That might be useful:

datafusion.sql_parser.dialect	generic	Configure the SQL dialect used by DataFusion’s parser; supported values include: Generic, MySQL, PostgreSQL, Hive, SQLite, Snowflake, Redshift, MsSQL, ClickHouse, BigQuery, and Ansi.

[chenkovsky]

I try to make genericdialect more customizable, but it seems that it maybe not a good idea. ಥ_ಥ

Note there is: https://datafusion.apache.org/user-guide/configs.html

That might be useful:

datafusion.sql_parser.dialect generic Configure the SQL dialect used by DataFusion’s parser; supported values include: Generic, MySQL, PostgreSQL, Hive, SQLite, Snowflake, Redshift, MsSQL, ClickHouse, BigQuery, and Ansi.

at the beginning, I want to implement a dialect which is similar to generic, but it seems that datafusion sql parser cannot support it easily. because too many dialect_of!. for OOP language, dialect_of! is ok, we can extend generic dialect, but for rust,dialect_of! may be not a good idea.