Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Default to some compression when writing Parquet #978

Open
kylebarron opened this issue Dec 19, 2024 · 1 comment · May be fixed by #981
Open

Default to some compression when writing Parquet #978

kylebarron opened this issue Dec 19, 2024 · 1 comment · May be fixed by #981
Labels
bug Something isn't working

Comments

@kylebarron
Copy link
Contributor

Describe the bug

Currently, the default parameters when writing to Parquet are no compression

def write_parquet(
self,
path: str | pathlib.Path,
compression: str = "uncompressed",
compression_level: int | None = None,
) -> None:

Since most high-level end users use the default parameters, I think this is a very bad footgun, and users will think Datafusion is doing something wrong.

To Reproduce

Expected behavior

Parquet files should be written with some compression by default. I'd suggest ZSTD.

Additional context
Add any other context about the problem here.

@kylebarron kylebarron added the bug Something isn't working label Dec 19, 2024
@kosiew
Copy link
Contributor

kosiew commented Dec 24, 2024

take

@kosiew kosiew linked a pull request Dec 24, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants