Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Speed up ConcurrentHashMap#computeIfAbsent of JDK8 #1244

Closed
SteNicholas opened this issue Jan 9, 2025 · 1 comment
Closed

Speed up ConcurrentHashMap#computeIfAbsent of JDK8 #1244

SteNicholas opened this issue Jan 9, 2025 · 1 comment
Labels
bug Something isn't working

Comments

@SteNicholas
Copy link
Member

Describe the bug

Comet supports JDK8, which could meet the bug mentioned in JDK-8161372.

Steps to reproduce

Introduce ConcurrentHashMapForJDK8 to check the key existence for speed up, which solves the bug JDK-8161372 to speed up ConcurrentHashMap#computeIfAbsent.

Expected behavior

No response

Additional context

No response
@SteNicholas SteNicholas added the bug Something isn't working label Jan 9, 2025
@SteNicholas SteNicholas mentioned this issue Jan 9, 2025
Closed
@andygrove
Copy link
Member

Closing this is "will not fix". See #1245 for discussion.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: speed up ConcurrentHashMap#computeIfAbsent of JDK8 SteNicholas/datafusion-comet
2 participants
@andygrove @SteNicholas