Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Setting the defaultlocale should update developmentRegion and knownRegions in pbxproj #1222

Open
ath0mas opened this issue Feb 10, 2022 · 0 comments
Milestone

Comments

@ath0mas
Copy link
Contributor

ath0mas commented Feb 10, 2022

Feature Request

Motivation Behind Feature

Since #237 adding a defaultlocale="XX" attribute to the widget tag in config.xml allows to set the CFBundleDevelopmentRegion to a different language (in the <project_name>-Info.plist file).

⇒ This same language should also be applied into the pbxproj files of the project and CordovaLib, to replace the hardcoded en from the templates for developmentRegion and knownRegions.

Feature Description

The templates for the project and CordovaLib are used to init the iOS project structure.

With previous #237, the __PROJECT_NAME__-Info.plist file is modified to target CFBundleDevelopmentRegion and replace the hardcoded value of en_US with the language set through defaultlocale.

Same should be done in project pbxproj file and CordovaLib pbxproj file, targeting developmentRegion (+) and knownRegions (+) and replacing the hardcoded value of en there too.

(may require apache/cordova-node-xcode#122?)

Alternatives or Workarounds

Custom script after platform add.

Or should I start a new cordova-plugin to add more defaults like this about locales? (to include this, apache/cordova-android#1396, kelvinhokk/cordova-plugin-localization-strings#65, and more?)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants