FtpFileObject.getChildren() should throw org.apache.commons.vfs2.FileNotFoundException instead of java.io.FileNotFoundException #638
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello @mareksunda From our README file:
Otherwise, good catch! |
|
Looks like the error is: |
…ead of preferred org.apache.commons.vfs2.FileNotFoundException
mareksunda
force-pushed
the
vfs-file-not-found-exception-inconsistency-ms
branch
from
6044d9a to
b85424f
Compare
|
Fixed. Apologies. I ran the tests, but not all.. embarrassing. |
@mareksunda |
garydgregory
changed the title
asfgit
pushed a commit
that referenced
this pull request
Nov 28, 2024
org.apache.commons.vfs2.FileNotFoundException instead of java.io.FileNotFoundException #638
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed consistency of wrongly using
java.io.FileNotFoundExceptioninstead of much preferredorg.apache.commons.vfs2.FileNotFoundException